[PATCH 5.15.y v1 1/1] mptcp: fix UAF of child socket on listener close

From: Jiayuan Chen

Date: Wed Nov 18 2026 - 07:51:42 EST


mptcp_close() orphans the listener subflow before inet_csk_listen_stop()
runs on it. A child created in that window inherits SOCK_DEAD, so a
following RST frees it while it is still in the accept queue:

close(listen_fd): 3-way handshake & rst (plain TCP client)

mptcp_close
// mark ssk as SOCK_DEAD
sock_orphan(ssk);
__mptcp_destroy_sock
// ssk in conn_list is listen sk
__mptcp_close_ssk
// in 3-way handshake
tcp_v4_syn_recv_sock
// inherit SOCK_DEAD state from listen ssk
inet_csk_clone_lock
// process RST
tcp_reset
tcp_done
// sk is SOCK_DEAD
inet_csk_destroy_sock
sock_put(sk); // freed
__tcp_close(ssk, 0)
// free child
inet_csk_listen_stop()
process child <==== process freed sk

refcount_t: addition on 0; use-after-free.
WARNING: CPU: 59 PID: 404175 at lib/refcount.c:25 refcount_warn_saturate+0x12e/0x150
RIP: 0010:refcount_warn_saturate+0x12e/0x150
Call Trace:
<TASK>
inet_csk_listen_stop+0x3e1/0x530
__tcp_close+0x3bc/0x440
__mptcp_close_ssk+0xb9/0x210
__mptcp_destroy_sock+0x11c/0x280
mptcp_close+0x25d/0x3b0
inet_release+0x44/0x90
__sock_release+0x42/0xb0
__fput+0x98/0x270
____fput+0xe/0x20
task_work_run+0x6d/0xb0
do_exit+0x1e7/0x3c0
do_group_exit+0x3b/0xb0
get_signal+0x17a/0x940
arch_do_signal_or_restart+0xba/0x130
exit_to_user_mode_loop+0xae/0x160
exit_to_user_mode_prepare+0xad/0xc0
irqentry_exit_to_user_mode+0x9/0x20
irqentry_exit+0x21/0x40
exc_page_fault+0x93/0x190
asm_exc_page_fault+0x27/0x30

Unhash the listener subflow and drain its accept queue before it is
orphaned. No new child can be queued after the unhash, and the ones
already queued are not SOCK_DEAD.

Upstream fixed this in commit 57fc0f1ceaa4 ("mptcp: ensure listener is
unhashed before updating the sk status"), which does not fit 5.15.

Fixes: e16163b6e2b7 ("mptcp: refactor shutdown and close")
Signed-off-by: Jiayuan Chen <jiayuan.chen@xxxxxxxxx>
---
net/mptcp/protocol.c | 10 ++++++++++
1 file changed, 10 insertions(+)

diff --git a/net/mptcp/protocol.c b/net/mptcp/protocol.c
index 2f18dcb8d..f1122038d 100644
--- a/net/mptcp/protocol.c
+++ b/net/mptcp/protocol.c
@@ -2834,6 +2834,16 @@ static void mptcp_close(struct sock *sk, long timeout)
sk->sk_shutdown = SHUTDOWN_MASK;

if ((1 << sk->sk_state) & (TCPF_LISTEN | TCPF_CLOSE)) {
+ struct sock *ssk = mptcp_sk(sk)->first;
+
+ if (ssk) {
+ lock_sock_nested(ssk, SINGLE_DEPTH_NESTING);
+ if (ssk->sk_state == TCP_LISTEN) {
+ tcp_set_state(ssk, TCP_CLOSE);
+ inet_csk_listen_stop(ssk);
+ }
+ release_sock(ssk);
+ }
inet_sk_state_store(sk, TCP_CLOSE);
goto cleanup;
}
--
2.43.0