Re: [PATCH v3 2/9] x86/virt/tdx: Read global metadata for trusted IOMMU
From: Binbin Wu
Date: Wed Nov 18 2026 - 08:39:32 EST
On 11/12/2026 12:30 PM, Lu Baolu wrote:
> Add support for reading the global metadata of the trusted IOMMU.
>
> The trusted IOMMU feature is optionally enumerated via TDX_FEATURES0.
Nit:
The feature enumerated is TDX Connect, I don't think they are interchangeable.
Trusted IOMMU is part of TDX Connect, right?
> Check this feature bit before reading the metadata to avoid causing
> the entire TDX initialization to fail on platforms that do not support
> it.
>
> The read value represents the number of pages required for the IOMMU
> metadata. The host will allocate this count of pages and provide them to
> the TDX module when it configures the IOMMU to operate in Secure TDX mode
> via the TDH.IOMMU.SETUP SEAMCALL.
>
> Signed-off-by: Lu Baolu <baolu.lu@xxxxxxxxxxxxxxx>
> ---
> arch/x86/include/asm/tdx.h | 1 +
> arch/x86/include/asm/tdx_global_metadata.h | 5 +++++
> arch/x86/virt/vmx/tdx/tdx_global_metadata.c | 20 ++++++++++++++++++++
> 3 files changed, 26 insertions(+)
>
> diff --git a/arch/x86/include/asm/tdx.h b/arch/x86/include/asm/tdx.h
> index d077990802b9..0ed0062c9b0a 100644
> --- a/arch/x86/include/asm/tdx.h
> +++ b/arch/x86/include/asm/tdx.h
> @@ -35,6 +35,7 @@
>
> /* Bit definitions of TDX_FEATURES0 metadata field */
> #define TDX_FEATURES0_TD_PRESERVING BIT_ULL(1)
> +#define TDX_FEATURES0_TDXCONNECT BIT_ULL(6)
> #define TDX_FEATURES0_NO_RBP_MOD BIT_ULL(18)
> #define TDX_FEATURES0_DYNAMIC_PAMT BIT_ULL(36)
> #define TDX_FEATURES0_EXT BIT_ULL(39)
> diff --git a/arch/x86/include/asm/tdx_global_metadata.h b/arch/x86/include/asm/tdx_global_metadata.h
> index f18e63b671c2..e5e54159ad36 100644
> --- a/arch/x86/include/asm/tdx_global_metadata.h
> +++ b/arch/x86/include/asm/tdx_global_metadata.h
> @@ -51,12 +51,17 @@ struct tdx_sys_info_ext {
> u32 required_pages;
> };
>
> +struct tdx_sys_info_connect {
> + u16 iommu_mt_page_count;
> +};
> +
> struct tdx_sys_info {
> struct tdx_sys_info_version version;
> struct tdx_sys_info_features features;
> struct tdx_sys_info_tdmr tdmr;
> struct tdx_sys_info_td_ctrl td_ctrl;
> struct tdx_sys_info_td_conf td_conf;
> + struct tdx_sys_info_connect tdx_connect;
> };
>
> #endif
> diff --git a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c b/arch/x86/virt/vmx/tdx/tdx_global_metadata.c
> index 9ab4d021017f..9b46f34cb469 100644
> --- a/arch/x86/virt/vmx/tdx/tdx_global_metadata.c
> +++ b/arch/x86/virt/vmx/tdx/tdx_global_metadata.c
> @@ -139,6 +139,20 @@ static __init int get_tdx_sys_info_ext(struct tdx_sys_info_ext *sysinfo_ext)
> return 0;
> }
>
> +static __init int get_tdx_sys_info_connect(struct tdx_sys_info_connect *sysinfo_connect)
> +{
> + int ret;
> + u64 val;
> +
> + ret = read_sys_metadata_field(0x3000000100000003, &val);
> + if (ret)
> + return ret;
> +
> + sysinfo_connect->iommu_mt_page_count = val;
> +
> + return 0;
> +}
> +
> static __init int get_tdx_sys_info(struct tdx_sys_info *sysinfo)
> {
> int ret = 0;
> @@ -164,5 +178,11 @@ static __init int get_tdx_sys_info(struct tdx_sys_info *sysinfo)
> if (!ret && tdx_supports_dynamic_pamt(sysinfo))
> ret = get_tdx_sys_info_tdmr_dpamt(&sysinfo->tdmr);
>
> + if (ret)
> + return ret;
> +
> + if (sysinfo->features.tdx_features0 & TDX_FEATURES0_TDXCONNECT)
> + ret = get_tdx_sys_info_connect(&sysinfo->tdx_connect);
> +
> return ret;
> }