Re: [RFC PATCH v14 2/4] blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary
From: bot+bpf-ci
Date: Wed Nov 18 2026 - 08:49:32 EST
> blk-iocost: add iocost_ioc_tick tracepoint for per-period device summary
TL;DR: The new iocost_ioc_tick tracepoint comment describes vrate as relative
to VTIME_PER_SEC, but it is likely vtime per usec (VTIME_PER_USEC is 100%), so
users following it would get values 10^6 too small.
> diff --git a/include/trace/events/iocost.h b/include/trace/events/iocost.h
> --- a/include/trace/events/iocost.h
> +++ b/include/trace/events/iocost.h
[ ... ]
> +/*
> + * Periodic per-device summary, emitted once per period before the vrate
> [ ... ]
> + * vrate is the current vrate in vtime units, where one IO time second
> + * is VTIME_PER_SEC (2^37) vtime and cost.vrate in io.stat reports the
> + * same value as a percentage of that base.
Is this description of vrate accurate? The field is filled from
ioc->vtime_base_rate, which is vtime per wall-clock microsecond:
__entry->vrate = ioc->vtime_base_rate;
and io.stat computes cost.vrate as a percentage of VTIME_PER_USEC, not
VTIME_PER_SEC:
unsigned vp10k = DIV64_U64_ROUND_CLOSEST(
ioc->vtime_base_rate * 10000,
VTIME_PER_USEC);
ioc_refresh_vrate() does the same with
div64_u64(ioc->vtime_base_rate * 100, VTIME_PER_USEC).
Someone following the comment would compute vrate * 100 / 2^37 and get a
value 10^6 too small, since the nominal 100% value is 137438 (2^37 / 10^6).
The commit message points readers to this header for the exact meaning of
the fields. Could the comment say that vrate is in vtime per wall-clock
usec, with VTIME_PER_USEC being 100% as reported by cost.vrate in io.stat?
[ ... ]
---
AI reviewed your patch. Please fix the bug or email reply why it's not a bug.
See: https://github.com/kernel-patches/vmtest/blob/master/ci/claude/README.md
CI run summary: https://github.com/kernel-patches/bpf/actions/runs/44312765238