Re: [PATCH 3/5] sched/core: Rank DL server picks as deadline in the core-wide pick

From: Peter Zijlstra

Date: Wed Nov 18 2026 - 08:53:04 EST


On Thu, Nov 12, 2026 at 06:15:46PM +0200, Fernand Sieber wrote:
> Commit 4b26cfdd3956 ("sched/core: Fix priority checking for DL server
> picks") made the core-wide selection rank a task picked through a DL
> server as deadline, so that a fair task competing with RT tasks under
> core scheduling still gets its server's bandwidth. It keys on
> p->dl_server, which pick_task() used to set.
>
> Since commit bd9bbc96e835 ("sched: Rework dl_server"), pick_task()
> records the server in rq->dl_server and p->dl_server is only set once
> the task is switched in. The core-wide selection still ranks each
> sibling's pick with prio_less(), so a task the sibling's server has
> just picked ranks as a plain fair or ext task and loses to an RT task
> on another sibling. The server's CPU then runs a task with the RT
> task's cookie or is forced idle, and the fair task gets none of the
> server's bandwidth for as long as the RT task runs.
>
> Rank each sibling's pick by the server it came through, rq_i->dl_server.
> prio_less() keeps using p->dl_server for the core tree, whose tasks are
> not being picked.
>

I don't love this, but I don't see another way either, so yes.