Re: [PATCH wireless-next v4 01/21] wifi: nl80211: define Seamless Mobility Domain (SMD) device capability

From: Pooventhiran G

Date: Wed Nov 18 2026 - 08:55:00 EST




On 11/16/2026 04:10 pm, Johannes Berg wrote:
> On Fri, 2026-11-13 at 20:53 +0530, Pooventhiran G wrote:
>>
>> On 11/10/2026 07:56 pm, Johannes Berg wrote:
>>> On Tue, 2026-11-10 at 15:15 +0100, Johannes Berg wrote:
>>>>> + * @NL80211_ATTR_SMD_SUPPORT: Flag attribute to indicate SMD support. Used with
>>>>> + * multiple commands to indicate appropriate SMD support (refer DOC).
>>>>
>>>> This (with the wiphy flag) is the wrong way to do this, we have extended
>>>> flags that don't need the double enum value and pass through to
>>>> userspace directly.
>>
>> I changed the EXT_FEATURE flag to WIPHY_FLAG based on the comments in v2 and
>> NL80211_ATTR_MLO_SUPPORT implementation.
>>
>
> Yes, but I think then you had more intricate feature advertisement and
> that went away entirely?
>

Start-ap had many SMD config params which are now cleaned up.

>> I will change this back to
>> EXT_FEATURE flag to indicate driver support.
>
> Sounds good.
>
>> NL80211_ATTR_SMD_SUPPORT passed to ieee80211_start_ap is parsed into link_conf
>> and (will be) read by the driver in assign_vif_chanctx drv-op. ath12k
>> implementation needs this indication to instantiate vifs and workflows in both
>> the driver and firmware.
>
> I guess that'll be one of those "trust me FW needs it" cases, but...
> why? I don't see how it has any impact on anything?
>

I will clean this up from start-ap as driver/firmware can manage without this.

> johannes