Re: [PATCH V1 2/2] Drivers: hv: Fix bugs and issues around repeat hypercall

From: Vitaly Kuznetsov

Date: Wed Nov 18 2026 - 09:01:55 EST


Mukesh R <mrathor@xxxxxxxxxxxxxxxxxxx> writes:

> On 11/17/26 09:41, Michael Kelley wrote:

...

>
> Confirming, that it is same behavior all the way back to 2016.
>
>> Sounds good. FWIW, old TLFS version 2.0A, which is specifically
>> titled to cover Windows Server 2008 R2, has the paragraph
>> about hypercall continuation. So that functionality was evidently
>> present very early on. It is still curious that Vitaly found it
>> necessary to include the looping behavior in the Linux guest
>> code.
>
> Maybe Vitaly was running into a genuine bug, not sure.
>

I'm not sure either :-(

WS2012 was definitely around back then, not sure about 2008. It may also
make sense to add at least a debug print in case we find ourselves
running on something that old. AFAICS, even the TLFS version 2.0A
mentions PV TLB flush hypercalls. If looping is still required for these
old versions, we may introduce some very hard-to-find bugs if we drop
it.

--
Vitaly