[PATCH 1/2] usb: gadget: fsl_udc: Fix potential use-after-free during removal
From: Guangshuo Li
Date: Wed Nov 18 2026 - 09:11:15 EST
usb_del_gadget_udc() can drop the last gadget device reference and call
fsl_udc_release(), which frees udc_controller. The remaining remove path
then dereferences it to release its requests, endpoints and DMA pool.
Hold a gadget device reference until this cleanup has finished.
This issue was found by our static analysis tool under development.
Fixes: eab35c4e6d95 ("usb: gadget: fsl_udc_core: let udc-core manage gadget->dev")
Cc: stable@xxxxxxxxxxxxxxx
Signed-off-by: Guangshuo Li <liguangshuo@xxxxxxxxxxxxxxx>
---
drivers/usb/gadget/udc/fsl_udc_core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/udc/fsl_udc_core.c b/drivers/usb/gadget/udc/fsl_udc_core.c
index 878d70b55530..9d9d2164c5bf 100644
--- a/drivers/usb/gadget/udc/fsl_udc_core.c
+++ b/drivers/usb/gadget/udc/fsl_udc_core.c
@@ -2537,6 +2537,7 @@ static void fsl_udc_remove(struct platform_device *pdev)
DECLARE_COMPLETION_ONSTACK(done);
udc_controller->done = &done;
+ get_device(&udc_controller->gadget.dev);
usb_del_gadget_udc(&udc_controller->gadget);
/* DR has been stopped in usb_gadget_unregister_driver() */
@@ -2554,6 +2555,7 @@ static void fsl_udc_remove(struct platform_device *pdev)
release_mem_region(res->start, resource_size(res));
/* free udc --wait for the release() finished */
+ put_device(&udc_controller->gadget.dev);
wait_for_completion(&done);
/*
--
2.43.0