[PATCH v2 02/12] EDAC/versalnet: Use designated initializer for rpmsg_channel_info

From: Shubhrajyoti Datta

Date: Wed Nov 18 2026 - 09:22:55 EST


Replace field-by-field assignment of struct rpmsg_channel_info with a
designated initializer. The old strscpy() call used strlen() as the
destination size, which truncated the channel name. Use the
string literal (via EDAC_RPMSG_CHAN_NAME) in the initializer so the
full name is passed to rpmsg_create_ept().

Fixes: d5fe2fec6c40 ("EDAC: Add a driver for the AMD Versal NET DDR controller")
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxx>
---

Changes in v2:
Use a macro for channel name

drivers/edac/versalnet_edac.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
index 89672d4d17c9..de97b2ac45aa 100644
--- a/drivers/edac/versalnet_edac.c
+++ b/drivers/edac/versalnet_edac.c
@@ -70,6 +70,8 @@
#define XDDR5_BUS_WIDTH_32 1
#define XDDR5_BUS_WIDTH_16 2

+#define EDAC_RPMSG_CHAN_NAME "error_ipc"
+
/**
* struct ecc_error_info - ECC error log information.
* @burstpos: Burst position.
@@ -713,21 +715,21 @@ static int rpmsg_cb(struct rpmsg_device *rpdev, void *data,
}

static struct rpmsg_device_id amd_rpmsg_id_table[] = {
- { .name = "error_ipc" },
+ { .name = EDAC_RPMSG_CHAN_NAME },
{ },
};
MODULE_DEVICE_TABLE(rpmsg, amd_rpmsg_id_table);

static int rpmsg_probe(struct rpmsg_device *rpdev)
{
- struct rpmsg_channel_info chinfo;
+ struct rpmsg_channel_info chinfo = {
+ .src = RPMSG_ADDR_ANY,
+ .dst = rpdev->dst,
+ .name = EDAC_RPMSG_CHAN_NAME,
+ };
struct mc_priv *pg;

pg = (struct mc_priv *)amd_rpmsg_id_table[0].driver_data;
- chinfo.src = RPMSG_ADDR_ANY;
- chinfo.dst = rpdev->dst;
- strscpy(chinfo.name, amd_rpmsg_id_table[0].name,
- strlen(amd_rpmsg_id_table[0].name));

pg->ept = rpmsg_create_ept(rpdev, rpmsg_cb, NULL, chinfo);
if (!pg->ept)
--
2.44.4