[PATCH v2 09/12] EDAC/versalnet: Move platform_set_drvdata() to mc_probe()
From: Shubhrajyoti Datta
Date: Wed Nov 18 2026 - 09:23:05 EST
Move platform_set_drvdata() out of init_one_mc() and into mc_probe()
so that the driver data is set once during probe rather than being
redundantly set on each memory controller initialization.
The pdev parameter in init_one_mc() and init_versalnet() is no longer
referenced. Remove it from both function signatures.
Reviewed-by: Radhey Shyam Pandey <radhey.shyam.pandey@xxxxxxx>
Signed-off-by: Shubhrajyoti Datta <shubhrajyoti.datta@xxxxxxx>
---
Changes in v2:
Add reviewed-by tag
drivers/edac/versalnet_edac.c | 11 +++++------
1 file changed, 5 insertions(+), 6 deletions(-)
diff --git a/drivers/edac/versalnet_edac.c b/drivers/edac/versalnet_edac.c
index 1a327a2dbda7..7c14f1e78da1 100644
--- a/drivers/edac/versalnet_edac.c
+++ b/drivers/edac/versalnet_edac.c
@@ -866,7 +866,7 @@ static void remove_one_mc(struct mc_priv *priv, int i)
device_unregister(dev);
}
-static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i)
+static int init_one_mc(struct mc_priv *priv, int i)
{
u32 num_chans, rank, dwidth, config;
struct edac_mc_layer layers[2];
@@ -940,8 +940,6 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i
priv->mci[i] = mci;
priv->dwidth[i] = dt;
- platform_set_drvdata(pdev, priv);
-
return 0;
err_mc_free:
@@ -954,12 +952,12 @@ static int init_one_mc(struct mc_priv *priv, struct platform_device *pdev, int i
return rc;
}
-static int init_versalnet(struct mc_priv *priv, struct platform_device *pdev)
+static int init_versalnet(struct mc_priv *priv)
{
int rc, i;
for (i = 0; i < NUM_CONTROLLERS; i++) {
- rc = init_one_mc(priv, pdev, i);
+ rc = init_one_mc(priv, i);
if (rc) {
while (i--)
remove_one_mc(priv, i);
@@ -1006,6 +1004,7 @@ static int mc_probe(struct platform_device *pdev)
}
priv->dev = &pdev->dev;
+ platform_set_drvdata(pdev, priv);
mutex_init(&priv->ept_lock);
init_completion(&priv->rpmsg_ready);
amd_rpmsg_id_table[0].driver_data = (kernel_ulong_t)priv;
@@ -1031,7 +1030,7 @@ static int mc_probe(struct platform_device *pdev)
for (i = 0; i < NUM_CONTROLLERS; i++)
get_ddr_config(i, &priv->adec[ADEC_NUM * i], priv->mcdi);
- rc = init_versalnet(priv, pdev);
+ rc = init_versalnet(priv);
if (rc)
goto err_init;
--
2.44.4