Re: [PATCH net v6 8/8] net/mlx5e: psp: tso: replace only the length in checksum seed

From: Dragos Tatulea

Date: Wed Nov 18 2026 - 09:25:14 EST


On 17.11.26 21:31, Todd Freed wrote:
> for psp tcp with tso,
>
> - __tcp_transmit_skb() -> tcp_v6_send_check() or tcp_v4_send_check()
> computes the checksum seed using the addresses on the socket and the
> total length, then
>
> - mlx5e_psp_handle_tx_skb() recomputes the checksum seed using
> addresses from the packet's l3 header, and the length of one segment
>
> the length difference is expected by the device. however, the difference
No cap in first char of sentence makes reading the commit message
harder. For example is this sentence standalone or a continuation?
Sorry for cramping your style.

> in addresses is incorrect in cases where the l3 header daddr is an
> intermediate hop, for example,
>
> - ipv4 source route option (IP_OPTIONS with lsrr or ssrr)
> - ipv6 IPV6_RTHDR header (conceptually ; ipv6 extension headers are not
> properly supported on this path yet)
>
> in these cases every segment of the tso packet to go out with a bad tcp
> checksum
What did you mean with "to go out" here? Goes out? Or is a verb missing?

>
> the fix is to replace only the length in the seed which tcp had already

> computed. this is also what tcp_gso_segment() does.
>
> tested on connectx-7, with a psp tcp socket whose ipv4 loose source
> route's first hop isn't the final destination, and the peer checking
> tcp checksums in software.
>
> Fixes: e5a1861a298e ("net/mlx5e: Implement PSP Tx data path")
> Acked-by: Daniel Zahka <daniel.zahka@xxxxxxxxx>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Todd Freed <toddfreed@xxxxxxxx>

Other than that:
Reviewed-by: Dragos Tatulea <dtatulea@xxxxxxxxxx>

Thanks,
Dragos