Re: [PATCH v4 0/5] drm/vc4: dsi: Make failed reads visible and recoverable
From: Maíra Canal
Date: Wed Nov 18 2026 - 09:35:32 EST
On 28/10/26 13:45, Henry Zhang wrote:
DSI reads on the Raspberry Pi 4 (vc4, DSI1) can fail in two ways thatApplied the first patch (1/5) to drm-misc-fixes, thanks!
the caller cannot handle:
- A peripheral that detected an error answers a read with an
Acknowledge and Error Report. vc4 copies its two bytes into the
caller's buffer and returns success, so the error bits look like
register contents (patch 2). An HSTX timeout can be reported as a
success as well (patch 1).
- After a read whose bus turnaround times out, every following DSI
transfer times out as well, until the display is switched off and on
(patch 5).
[...]
I'll leave the review of the rest of the patches for Dave, as he has
more expertise on the DSI side. Anyway, you should consider addressing
Sashiko's comment on 4/5.
Best regards,
- Maíra