Re: [PATCH v1 1/2] dt-bindings: i2c: Document ASUS Transformer's Dock

From: Svyatoslav Ryhel

Date: Wed Nov 18 2026 - 09:42:58 EST


ср, 18 лист. 2026 р. о 16:40 Wolfram Sang
<wsa+renesas@xxxxxxxxxxxxxxxxxxxx> пише:
>
>
> > .../bindings/i2c/asus,transformer-dock.yaml | 56 +++++++++++++++++++
> > 1 file changed, 56 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/i2c/asus,transformer-dock.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/i2c/asus,transformer-dock.yaml b/Documentation/devicetree/bindings/i2c/asus,transformer-dock.yaml
> > new file mode 100644
> > index 0000000000000..5f4a40539c2b4
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/i2c/asus,transformer-dock.yaml
>
> This is not an I2C controller, so "i2c" is not the proper directory, I'd
> say. "connector" maybe? DT maintainers may have another suggestion.
>

I have placed it here arbitrary. I am perfectly fine with any place
schema maintainers point to.

> > +allOf:
> > + - $ref: /schemas/i2c/i2c-controller.yaml
>
> Hmm, this bindings only uses "i2c-parent" which is not even described in
> the above file. Not your fault / problem, but we should describe it
> somewhen somewhere central maybe? I guess the above $ref could be
> dropped still.
>

Child nodes too. IIRC i2c-controller.yaml covers those.

> No comments on the general approach, I'll leave this to DT and Asus
> platform maintainers.
>