Re: [PATCH v2 0/3] mm/memory: remove unused vmf_insert_mixed_mkwrite()

From: David Hildenbrand (Arm)

Date: Wed Nov 18 2026 - 09:49:09 EST


On 10/2/26 18:05, Sang-Heon Jeon wrote:
> Hello,
>
> Since commit 38607c62b34b ("fs/dax: properly refcount fs dax pages"),
> vmf_insert_mixed_mkwrite() has no callers. This series removes it and
> the mkwrite handling that only it used.
>
> Patch 1 removes the function.
>
> Patch 2 removes the mkwrite argument, which is then always false. It
> also removes the unreachable code in insert_pfn().
>
> Patch 3 merges __vm_insert_mixed() into vmf_insert_mixed().
>
> No functional change.
>
> ---
> Changes from v1 [1]
> - Split into three patches for easier review
> - Move the comment about -EBUSY handling above the check in
> __vm_insert_mixed()
>
> [1] https://lore.kernel.org/all/20260929143707.450805-1-ekffu200098@xxxxxxxxx/
> ---
>
> Sang-Heon Jeon (3):
> mm/memory: remove unused vmf_insert_mixed_mkwrite()
> mm/memory: remove the mkwrite argument from __vm_insert_mixed()
> mm/memory: merge __vm_insert_mixed() into vmf_insert_mixed()

Hi Andrew,

please drop these changes, I'll queue them myself after applying a fix from Mike
in that area.

--
Cheers,

David