Re: [PATCH net v2 2/3] igb: link queues to NAPIs under RTNL after runtime resume
From: Joe Damato
Date: Wed Nov 18 2026 - 10:05:37 EST
On Mon, Nov 16, 2026 at 04:30:38PM +0100, Antonio Quartulli wrote:
> __igb_open() links queues to NAPIs with netif_queue_set_napi(), which
> requires RTNL, but RTNL isn't held when resuming from runtime suspend:
> this triggers "RTNL: assertion failed".
>
> Don't link them in __igb_open() when resuming: do it right away on
> system resume (RTNL held) and from a work item taking RTNL on runtime
> resume. The links can't be kept across a suspend, because
> __igb_shutdown() frees the q_vectors. These are only freed under RTNL
> with __IGB_DOWN set, so the work item checks __IGB_DOWN under RTNL.
>
> Tested with the 82576 emulated by QEMU.
>
> Fixes: b75a1dea500f ("igb: Link queues to NAPI instances")
> Cc: stable@xxxxxxxxxxxxxxx # 6.16+
> Closes: https://bugzilla.ipfire.org/show_bug.cgi?id=13562
> Signed-off-by: Antonio Quartulli <antonio@xxxxxxxxxxxxx>
> ---
> v2: no code changes; mention the tested hardware.
>
> Note: igc may have the same issue: __igc_open() also links queues to NAPIs
> (igc_set_queue_napi()) on the RTNL-less runtime resume path. We didn't
> have igc hardware to test a fix with, so no igc patch is sent for now.
I have an igc I can test on if you want to send me the script you used to test
this. Feel free to message me off list if you like.
> drivers/net/ethernet/intel/igb/igb.h | 1 +
> drivers/net/ethernet/intel/igb/igb_main.c | 38 +++++++++++++++++++++--
> 2 files changed, 37 insertions(+), 2 deletions(-)
Reviewed-by: Joe Damato <joe@xxxxxxx>