Re: [PATCH v3 0/9] userfaultfd: assorted fixes (part 1)

From: David Hildenbrand (Arm)

Date: Wed Nov 18 2026 - 10:38:26 EST


On 11/18/26 16:26, Tal Zussman wrote:
> On 11/18/26 4:41 AM, David Hildenbrand (Arm) wrote:
>> On 11/18/26 05:28, Tal Zussman wrote:
> ...
>
>>> Patch 6 has little user impact on its own. It is included because,
>>> together with patch 7, it allows removing clear_uffd_wp_pmd().
>>>
>
> ...>
>> So, I would be picking up ...
>>
>>> Tal Zussman (9):
>>> userfaultfd: use anonymous memory for UFFDIO_ZEROPAGE on private file mappings
>>> userfaultfd: refuse UFFDIO_MOVE into a non-present huge destination PMD
>>> fs/proc/task_mmu: downgrade writable migration entries in PAGEMAP_SCAN write-protect
>>> mm/migrate: warn on a writable migration entry with the uffd bit set
>>
>> This
>>
>>> fs/proc/task_mmu: write-protect device-private THPs in PAGEMAP_SCAN
>>> mm/huge_memory: build the moved huge zero PMD from the destination VMA
>>
>> This
>>
>
> So my one concern is that (as per above), the mremap patch removes
> clear_uffd_wp_pmd() after the huge_memory patch removes the other user.
> Splitting them may break compilation. I would've left clear_uffd_wp_pmd()
> alone but then it throws a nice ugly unused code warning :\

Ah, so it's best Andrew picks that up as well then?

--
Cheers,

David