[PATCH v3 3/4] remoteproc: qcom: pas: Add coredump support for secondary processors

From: Anvesh Jain P

Date: Wed Nov 18 2026 - 10:39:13 EST


Add coredump support for PAS remoteproc instances with a secondary
processor by registering dump segments for both PAS firmware images and
temporarily mapping their carveouts during collection. This is for debug
dump collection and does not provide operational device recovery.

Signed-off-by: Anvesh Jain P <anvesh.p@xxxxxxxxxxxxxxxx>
---
drivers/remoteproc/qcom_q6v5_pas.c | 67 +++++++++++++++++++++++++++++++++++---
1 file changed, 62 insertions(+), 5 deletions(-)

diff --git a/drivers/remoteproc/qcom_q6v5_pas.c b/drivers/remoteproc/qcom_q6v5_pas.c
index 1c8c0c22c34d..a167bd6072c9 100644
--- a/drivers/remoteproc/qcom_q6v5_pas.c
+++ b/drivers/remoteproc/qcom_q6v5_pas.c
@@ -138,6 +138,7 @@ struct qcom_pas {
phys_addr_t region_assign_phys[MAX_ASSIGN_COUNT];

void __iomem *mem_region;
+ void __iomem *secondary_mem_region;

size_t mem_size;
size_t dtb_mem_size;
@@ -185,6 +186,11 @@ static void qcom_pas_segment_dump(struct rproc *rproc,
memcpy_fromio(dest, pas->mem_region + total_offset, size);
}

+static bool qcom_pas_has_secondary(const struct qcom_pas *pas)
+{
+ return pas->secondary_pas_id && pas->secondary_dtb_pas_id;
+}
+
static void qcom_pas_minidump(struct rproc *rproc)
{
struct qcom_pas *pas = rproc->priv;
@@ -336,6 +342,17 @@ static int qcom_pas_load(struct rproc *rproc, const struct firmware *fw)
}
}

+ if (pas->secondary_pas_id) {
+ ret = qcom_register_dump_segments(rproc, pas->secondary_firmware);
+ if (ret) {
+ dev_err(pas->dev,
+ "failed to register secondary dump segments: %d\n", ret);
+ rproc_coredump_cleanup(rproc);
+ qcom_pas_release_firmware(pas);
+ return ret;
+ }
+ }
+
return 0;
}

@@ -611,16 +628,38 @@ static int qcom_pas_stop(struct rproc *rproc)
static void *qcom_pas_da_to_va(struct rproc *rproc, u64 da, size_t len, bool *is_iomem)
{
struct qcom_pas *pas = rproc->priv;
- int offset;
+ phys_addr_t base;
+ void __iomem *region;
+
+ if (da >= pas->mem_reloc && len <= pas->mem_size &&
+ da - pas->mem_reloc <= pas->mem_size - len) {
+ base = pas->mem_reloc;
+ region = pas->mem_region;
+ } else if (da >= pas->mem_phys && len <= pas->mem_size &&
+ da - pas->mem_phys <= pas->mem_size - len) {
+ base = pas->mem_phys;
+ region = pas->mem_region;
+ } else if (da >= pas->secondary_mem_reloc &&
+ len <= pas->secondary_mem_size &&
+ da - pas->secondary_mem_reloc <= pas->secondary_mem_size - len) {
+ base = pas->secondary_mem_reloc;
+ region = pas->secondary_mem_region;
+ } else if (da >= pas->secondary_mem_phys &&
+ len <= pas->secondary_mem_size &&
+ da - pas->secondary_mem_phys <= pas->secondary_mem_size - len) {
+ base = pas->secondary_mem_phys;
+ region = pas->secondary_mem_region;
+ } else {
+ return NULL;
+ }

- offset = da - pas->mem_reloc;
- if (offset < 0 || offset + len > pas->mem_size)
+ if (!region)
return NULL;

if (is_iomem)
*is_iomem = true;

- return (__force void *)pas->mem_region + offset;
+ return (__force void *)region + (da - base);
}

static int qcom_pas_parse_firmware(struct rproc *rproc, const struct firmware *fw)
@@ -748,11 +787,28 @@ static void qcom_pas_coredump(struct rproc *rproc)
{
struct qcom_pas *pas = rproc->priv;

- pas->mem_region = qcom_pas_ctx_map(pas->pas_ctx);
+ if (list_empty(&rproc->dump_segments))
+ return;
+
+ if (!pas->mem_region)
+ pas->mem_region = qcom_pas_ctx_map(pas->pas_ctx);
if (!pas->mem_region)
return;

+ if (qcom_pas_has_secondary(pas) && !pas->secondary_mem_region) {
+ pas->secondary_mem_region =
+ qcom_pas_ctx_map(pas->secondary_pas_ctx);
+ if (!pas->secondary_mem_region)
+ dev_err(pas->dev, "unable to map secondary memory for coredump\n");
+ }
+
rproc_coredump(rproc);
+
+ if (pas->secondary_mem_region) {
+ iounmap(pas->secondary_mem_region);
+ pas->secondary_mem_region = NULL;
+ }
+
iounmap(pas->mem_region);
pas->mem_region = NULL;
}
@@ -1276,6 +1332,7 @@ static void qcom_pas_remove(struct platform_device *pdev)
of_platform_device_destroy(&pas->bam_dmux->dev, NULL);

rproc_del(pas->rproc);
+ rproc_coredump_cleanup(pas->rproc);

if (pas->tmd_inst)
qmi_tmd_exit(pas->tmd_inst);

--
2.34.1