Re: [PATCH mm-new v2 1/5] mm: remove unused helpers from pagemap.h
From: Dev Jain
Date: Wed Nov 18 2026 - 11:12:11 EST
On 17/11/26 12:46 pm, Shivank Garg wrote:
> invalidate_remote_inode() lost its last user in commit d73065e60dcc
> ("afs: Use alternative invalidation to using launder_folio").
> mapping_clear_release_always() has no callers.
That was added in b4fa966f03b7401ceacd4ffd7227197afb2b8376.
>
> Signed-off-by: Shivank Garg <shivankg@xxxxxxx>
> ---
Reviewed-by: Dev Jain <dev.jain@xxxxxxx>
> include/linux/pagemap.h | 11 -----------
> 1 file changed, 11 deletions(-)
>
> diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
> index 73af18a37367..e681a7ba6642 100644
> --- a/include/linux/pagemap.h
> +++ b/include/linux/pagemap.h
> @@ -20,12 +20,6 @@ struct folio_batch;
> unsigned long invalidate_mapping_pages(struct address_space *mapping,
> pgoff_t start, pgoff_t end);
>
> -static inline void invalidate_remote_inode(struct inode *inode)
> -{
> - if (S_ISREG(inode->i_mode) || S_ISDIR(inode->i_mode) ||
> - S_ISLNK(inode->i_mode))
> - invalidate_mapping_pages(inode->i_mapping, 0, -1);
> -}
> int invalidate_inode_pages2(struct address_space *mapping);
> int invalidate_inode_pages2_range(struct address_space *mapping,
> pgoff_t start, pgoff_t end);
> @@ -298,11 +292,6 @@ static inline void mapping_set_release_always(struct address_space *mapping)
> set_bit(AS_RELEASE_ALWAYS, &mapping->flags);
> }
>
> -static inline void mapping_clear_release_always(struct address_space *mapping)
> -{
> - clear_bit(AS_RELEASE_ALWAYS, &mapping->flags);
> -}
> -
> static inline bool mapping_stable_writes(const struct address_space *mapping)
> {
> return test_bit(AS_STABLE_WRITES, &mapping->flags);
>