Re: [PATCH v4 1/2] coccinelle: Add offsetofend() variant of struct_offset()

From: Markus Elfring

Date: Wed Nov 18 2026 - 11:19:31 EST


…
> +++ b/scripts/coccinelle/api/struct_offsetof.cocci
> @@ -0,0 +1,18 @@
> +// SPDX-License-Identifier: GPL-2.0-only
> +/// Use struct_offset() family of macros
> +///
> +// Confidence: High
> +// Options: --no-includes --ignore ./tools/
> +
> +virtual patch

Can further coccicheck operation modes become more interesting here?


> +
> +@offsetof depends on patch@
> +expression ptr, member;
> +@@
> +- offsetof(typeof(*(ptr)), member)
> ++ struct_offset(ptr, member)
> +@offsetofend depends on patch@
> +expression ptr, member;
> +@@
> +- offsetofend(typeof(*(ptr)), member)
> ++ struct_offsetofend(ptr, member)

How do you think about to use the following SmPL rule variant instead?


@replacement depends on patch@
expression pointer, member;
@@
(
-offsetof
+struct_offset
|
-offsetofend
+struct_offsetofend
)(
-typeof(*
-(pointer)
+pointer
-)
, member
)


Regards,
Markus