[PATCH] iio: magnetometer: rm3100: check TMRC in rm3100_get_samp_freq()
From: Maoyi Xie
Date: Wed Nov 18 2026 - 11:41:18 EST
rm3100_get_samp_freq() reads TMRC from the sensor and uses the value
minus RM3100_TMRC_OFFSET as an index into rm3100_samp_rates[] without a
check. A value outside 0x92 to 0x9f reads outside the table. The driver
only writes values in that range, so this needs a chip or bus that
misbehaves after probe.
Commit 792595bab492 ("iio: magnetometer: rm3100: add boundary check for
the value read from RM3100_REG_TMRC") added the check to
rm3100_common_probe() after a crash on failing hardware. Do the same
here and return -EINVAL.
Found with a CodeQL-based static analysis tool that we are developing.
Reproduced in a userspace harness under ASan and UBSan, which report
nothing with this patch. Not tested on hardware, only compile-tested
with W=1 on next-20261116.
Fixes: 121354b2eceb ("iio: magnetometer: Add driver support for PNI RM3100")
Co-developed-by: Praveen Kakkolangara <praveen.kakkolangara@xxxxxxxxxxx>
Signed-off-by: Praveen Kakkolangara <praveen.kakkolangara@xxxxxxxxxxx>
Signed-off-by: Maoyi Xie <maoyixie.tju@xxxxxxxxx>
---
I used an LLM to help write the harness and this patch.
drivers/iio/magnetometer/rm3100-core.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/iio/magnetometer/rm3100-core.c b/drivers/iio/magnetometer/rm3100-core.c
index 46fce2978d76705..2fec02e5679eaf7 100644
--- a/drivers/iio/magnetometer/rm3100-core.c
+++ b/drivers/iio/magnetometer/rm3100-core.c
@@ -279,6 +279,7 @@ static int rm3100_get_samp_freq(struct rm3100_data *data, int *val, int *val2)
{
unsigned int tmp;
int ret;
+ int samp_rate_index;
guard(mutex)(&data->lock);
@@ -286,8 +287,12 @@ static int rm3100_get_samp_freq(struct rm3100_data *data, int *val, int *val2)
if (ret < 0)
return ret;
- *val = rm3100_samp_rates[tmp - RM3100_TMRC_OFFSET][0];
- *val2 = rm3100_samp_rates[tmp - RM3100_TMRC_OFFSET][1];
+ samp_rate_index = tmp - RM3100_TMRC_OFFSET;
+ if (samp_rate_index < 0 || samp_rate_index >= RM3100_SAMP_NUM)
+ return -EINVAL;
+
+ *val = rm3100_samp_rates[samp_rate_index][0];
+ *val2 = rm3100_samp_rates[samp_rate_index][1];
return IIO_VAL_INT_PLUS_MICRO;
}
base-commit: 7e1392a42ea288d70a266f6553fe06f57f8647ea
--
2.34.1