[PATCH RFC v3 26/31] drm/atomic: add drm_atomic_shutdown_encoder()
From: Luca Ceresoli
Date: Wed Nov 18 2026 - 11:54:48 EST
To support bridge hotplug we need to stop the components of a card that are
affected by the removal of a bridge: the connector, the encoder and
possibly the CRTC (unless it is still in use after the removal due to
cloning).
drm_atomic_helper_shutdown() does it, but it disables the entire card,
including unrelated CRTCs for multi-CRTC cards. Moreover it is in the
drm_kms_helper module, which makes it unaccessible from the core code where
we need this.
Add drm_atomic_shutdown_encoder() to drm_atomic code, doing what we need.
Signed-off-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx>
---
New patch in v3
---
drivers/gpu/drm/drm_atomic.c | 145 +++++++++++++++++++++++++++++++++++++++++++
include/drm/drm_atomic.h | 1 +
2 files changed, 146 insertions(+)
diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c
index ad2099b4dffd..7015ee18462c 100644
--- a/drivers/gpu/drm/drm_atomic.c
+++ b/drivers/gpu/drm/drm_atomic.c
@@ -2148,6 +2148,151 @@ int __drm_atomic_helper_set_config(struct drm_mode_set *set,
}
EXPORT_SYMBOL(__drm_atomic_helper_set_config);
+static int drm_atomic_disable_encoder(struct drm_device *drm,
+ struct drm_encoder *encoder,
+ struct drm_modeset_acquire_ctx *ctx)
+{
+ struct drm_connector_list_iter conn_iter;
+ struct drm_connector *connector;
+ struct drm_crtc *crtc = NULL;
+ struct drm_atomic_commit *commit;
+ struct drm_crtc_state *crtc_state;
+ bool crtc_still_used = false;
+ int ret;
+
+ drm_connector_list_iter_begin(drm, &conn_iter);
+ drm_for_each_connector_iter(connector, &conn_iter) {
+ if (!connector->state ||
+ connector->state->best_encoder != encoder ||
+ !connector->state->crtc)
+ continue;
+
+ crtc = connector->state->crtc;
+ break;
+ }
+ drm_connector_list_iter_end(&conn_iter);
+
+ if (!crtc)
+ return 0;
+
+ commit = drm_atomic_commit_alloc(drm);
+ if (!commit)
+ return -ENOMEM;
+
+ commit->acquire_ctx = ctx;
+
+ crtc_state = drm_atomic_get_crtc_state(commit, crtc);
+ if (IS_ERR(crtc_state)) {
+ ret = PTR_ERR(crtc_state);
+ goto free;
+ }
+
+ drm_connector_list_iter_begin(drm, &conn_iter);
+ drm_for_each_connector_iter(connector, &conn_iter) {
+ struct drm_connector_state *conn_state;
+
+ if (!connector->state || connector->state->crtc != crtc)
+ continue;
+
+ if (connector->state->best_encoder != encoder) {
+ crtc_still_used = true;
+ continue;
+ }
+
+ conn_state = drm_atomic_get_connector_state(commit, connector);
+ if (IS_ERR(conn_state)) {
+ ret = PTR_ERR(conn_state);
+ drm_connector_list_iter_end(&conn_iter);
+ goto free;
+ }
+ }
+ drm_connector_list_iter_end(&conn_iter);
+
+ if (crtc_still_used) {
+ struct drm_connector_state *conn_state;
+ int i;
+
+ /* Some connector still uses @crtc, keep it and its planes enabled */
+ for_each_new_connector_in_state(commit, connector, conn_state, i) {
+ ret = drm_atomic_set_crtc_for_connector(conn_state, NULL);
+ if (ret < 0)
+ goto free;
+ }
+ } else {
+ struct drm_connector_state *conn_state;
+ struct drm_plane_state *plane_state;
+ struct drm_plane *plane;
+ int i;
+
+ crtc_state->active = false;
+
+ ret = drm_atomic_set_mode_prop_for_crtc(crtc_state, NULL);
+ if (ret < 0)
+ goto free;
+
+ ret = drm_atomic_add_affected_planes(commit, crtc);
+ if (ret < 0)
+ goto free;
+
+ ret = drm_atomic_add_affected_connectors(commit, crtc);
+ if (ret < 0)
+ goto free;
+
+ for_each_new_connector_in_state(commit, connector, conn_state, i) {
+ ret = drm_atomic_set_crtc_for_connector(conn_state, NULL);
+ if (ret < 0)
+ goto free;
+ }
+
+ for_each_new_plane_in_state(commit, plane, plane_state, i) {
+ ret = drm_atomic_set_crtc_for_plane(plane_state, NULL);
+ if (ret < 0)
+ goto free;
+
+ drm_atomic_set_fb_for_plane(plane_state, NULL);
+ }
+ }
+
+ ret = drm_atomic_commit(commit);
+free:
+ drm_atomic_commit_put(commit);
+ return ret;
+}
+
+/**
+ * drm_atomic_shutdown_encoder - shutdown the pipeline behind an encoder
+ * @encoder: encoder whose pipeline should be shut down
+ *
+ * Stop the output currently driven by @encoder. Also shutdown the
+ * connected CRTC unless other connectors are still attached to it
+ * (e.g. cloning).
+ */
+void drm_atomic_shutdown_encoder(struct drm_encoder *encoder)
+{
+ struct drm_modeset_acquire_ctx ctx;
+ struct drm_device *dev;
+ int ret;
+
+ if (!encoder)
+ return;
+
+ dev = encoder->dev;
+ if (!dev)
+ return;
+
+ if (!drm_drv_uses_atomic_modeset(dev))
+ return;
+
+ DRM_MODESET_LOCK_ALL_BEGIN(dev, ctx, 0, ret);
+
+ ret = drm_atomic_disable_encoder(dev, encoder, &ctx);
+ if (ret)
+ drm_err(dev, "Disabling CRTC for encoder %s failed with %i\n", encoder->name, ret);
+
+ DRM_MODESET_LOCK_ALL_END(dev, ctx, ret);
+}
+EXPORT_SYMBOL(drm_atomic_shutdown_encoder);
+
static void drm_atomic_private_obj_print_state(struct drm_printer *p,
const struct drm_private_state *state)
{
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index 3ae35b09c0cf..5b6d5e8423a5 100644
--- a/include/drm/drm_atomic.h
+++ b/include/drm/drm_atomic.h
@@ -1409,5 +1409,6 @@ drm_atomic_get_old_bridge_state(const struct drm_atomic_commit *state,
struct drm_bridge_state *
drm_atomic_get_new_bridge_state(const struct drm_atomic_commit *state,
struct drm_bridge *bridge);
+void drm_atomic_shutdown_encoder(struct drm_encoder *encoder);
#endif /* DRM_ATOMIC_H_ */
--
2.56.1