Re: [PATCH v2 2/5] locking/rtmutex: Initialize the ww_mutex context of a waiter

From: Mathieu Desnoyers

Date: Wed Nov 18 2026 - 12:29:58 EST


Hi Sebastian,

> The deference _shouldn't_ happen because those two a different. However,
> we could have a mix of those two and which point it becomes relevant.

Agreed. It needs a chain that mixes both. I dropped that paragraph.

> I would strip that paragraph because *I* think it is more important to
> mention the FUTEX case which no longer does proper chainwalk regardless
> of PREEMPT_RT.

One point. The two tests of ww_ctx in rt_mutex_adjust_prio_chain() are
under IS_ENABLED(CONFIG_PREEMPT_RT). Without PREEMPT_RT,
futex_lock_pi_inherit gets EDEADLK in both cases, with or without this
patch. So I kept the PREEMPT_RT condition in the message. Did you have
another path in mind?

With your changes, the message reads:

rt_mutex_init_waiter() does not set rt_mutex_waiter::ww_ctx. Only
__rt_mutex_slowlock_locked() sets it. So the waiters of PI futexes
and rtlocks keep the 0x11 poison of CONFIG_DEBUG_RT_MUTEXES, or
random garbage without that option.

The futex code for FUTEX_LOCK_PI performs a RT_MUTEX_FULL_CHAINWALK
during locking:

futex_lock_pi()
rt_mutex_init_waiter()
__rt_mutex_start_proxy_lock()
task_blocks_on_rt_mutex()
rt_mutex_adjust_prio_chain()

With PREEMPT_RT, rt_mutex_adjust_prio_chain() then wrongly assumes
that it is a ww_mutex, due to the garbage in rt_mutex_waiter::ww_ctx.
It does not report a deadlock, but expects the caller to handle it.
Two threads that each block on a PI futex the other holds then sleep
forever. Without PREEMPT_RT, the second one gets EDEADLK.
FUTEX_LOCK_PI also blocks on a chain deeper than max_lock_depth,
instead of returning EDEADLK.

Fix this by clearing rt_mutex_waiter::ww_ctx in
rt_mutex_init_waiter().

With this patch, FUTEX_LOCK_PI returns EDEADLK in both cases. The
futex_lock_pi_inherit selftest added later in this series found
this, with PREEMPT_RT and CONFIG_DEBUG_RT_MUTEXES. Its deadlock and
max_lock_depth cases cover it.

> This, Fixes: and
>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>

Thanks!

Mathieu


--
Mathieu Desnoyers
EfficiOS Inc.
https://www.efficios.com