[PATCH v3 12/14] irqchip/gic-v5: Retain the ITT when device invalidation times out
From: Sascha Bischoff
Date: Wed Nov 18 2026 - 12:36:53 EST
Device registration publishes a DTE pointing to the new ITT before
invalidating the ITS device cache. If invalidation times out, clearing
the DTE in memory does not guarantee that the ITS has discarded a
cached reference to the ITT, and hence the hardware could still try
and access the memory. Freeing the ITT on that path can therefore
leave the ITS accessing memory that has been reallocated.
Device teardown has the same problem: it frees the ITT even when the
invalidation issued after clearing the DTE fails to complete in the
specified timeout.
Retain the ITT on either failure path. Continue returning the
invalidation error, and free the ITT during teardown only after
successful completion. This deliberately retains memory on hardware
failure because a timeout does not cancel the operation or establish
that cached references are gone.
Fixes: 57d72196dfc85 ("irqchip/gic-v5: Add GICv5 ITS support")
Reported-by: Fuad Tabba <fuad.tabba@xxxxxxxxx>
Signed-off-by: Sascha Bischoff <sascha.bischoff@xxxxxxx>
Link: https://lore.kernel.org/r/20261112145814.853424-1-fuad.tabba@xxxxxxxxx
---
drivers/irqchip/irq-gic-v5-its.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/irqchip/irq-gic-v5-its.c b/drivers/irqchip/irq-gic-v5-its.c
index db13011ef6d93..cfa86aa68bf3c 100644
--- a/drivers/irqchip/irq-gic-v5-its.c
+++ b/drivers/irqchip/irq-gic-v5-its.c
@@ -540,8 +540,8 @@ static int gicv5_its_device_register(struct gicv5_its_chip_data *its,
ret = gicv5_its_device_cache_inv(its, its_dev);
if (ret) {
+ /* The ITS may still have a cached reference to the ITT. */
its_write_table_entry(its, dte, 0);
- gicv5_its_free_itt(its_dev);
return ret;
}
@@ -570,7 +570,9 @@ static int gicv5_its_device_unregister(struct gicv5_its_chip_data *its,
its_write_table_entry(its, dte, 0);
ret = gicv5_its_device_cache_inv(its, its_dev);
- gicv5_its_free_itt(its_dev);
+ /* Only release the ITT once the ITS has discarded its references. */
+ if (!ret)
+ gicv5_its_free_itt(its_dev);
return ret;
}
--
2.34.1