Re: [PATCH v2] scsi: pm8001: Offset hardware queue index for MSI-X pre-vector

From: TJ Adams

Date: Wed Nov 18 2026 - 12:38:22 EST


On Tue, Nov 17, 2026 at 11:27 AM Bart Van Assche <bvanassche@xxxxxxx> wrote:
>
> The surrounding definitions have a tab between "#define" and the
> macro name, while this one has a space. Is this intentional?

No, this was unintentional. My editor rendered the tab as one column
after #define, so I didn't notice. I'll fix this in v3.

> A side effect of this change: completions for the highest hardware
> queue now go to outbound queue max_q_num - 1. pm80xx_chip_init()
> programs that vector as the fatal error interrupt. process_oq() reads
> MSGU_SCRATCH_PAD_1 for every interrupt on that vector, and also
> MSGU_SCRATCH_PAD_RSVD_0 if no fatal error is reported. Without this
> patch, no I/O completions go to that queue, so those MMIO reads only
> happen for fatal error interrupts. The code is still correct, and the
> driver used that queue for I/O before commit 42f22fe36d51 too, but it
> might be worth mentioning in the patch description. Alternatively, a
> follow-up patch could move the fatal error interrupt to the
> housekeeping vector.

Thanks for pointing that out! I'll just mention it in the v3 patch
description since I haven't tested moving the fatal error interrupt to
the housekeeping vector.

Thanks for the review,
TJ