Re: [PATCH v4 13/21] KVM: x86/pmu: Emulate IA32_PERF_GLOBAL_STATUS_SET MSR
From: Chen, Zide
Date: Wed Nov 18 2026 - 12:59:36 EST
On 11/18/2026 10:12 AM, Yosry Ahmed wrote:
>> diff --git a/arch/x86/kvm/pmu.c b/arch/x86/kvm/pmu.c
>> index 7ba1a3b38184..bd5954e62080 100644
>> --- a/arch/x86/kvm/pmu.c
>> +++ b/arch/x86/kvm/pmu.c
>> @@ -855,6 +855,7 @@ int kvm_pmu_get_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>> case MSR_AMD64_PERF_CNTR_GLOBAL_STATUS_CLR:
>> case MSR_AMD64_PERF_CNTR_GLOBAL_STATUS_SET:
>> case MSR_CORE_PERF_GLOBAL_OVF_CTRL:
>> + case MSR_CORE_PERF_GLOBAL_STATUS_SET:
>> msr_info->data = 0;
>> break;
>> default:
>> @@ -923,6 +924,12 @@ int kvm_pmu_set_msr(struct kvm_vcpu *vcpu, struct msr_data *msr_info)
>> if (!msr_info->host_initiated)
>> pmu->global_status &= ~data;
>> break;
>> + case MSR_CORE_PERF_GLOBAL_STATUS_SET:
>> + if (data & pmu->global_status_rsvd)
>> + return 1;
>> + if (!msr_info->host_initiated)
>> + pmu->global_status |= data;
>> + break;
>
> Nit: Perhaps we should follow what MSR_CORE_PERF_GLOBAL_OVF_CTRL does
> and fallthrough, leaving the pmu->global_status update shared with
> MSR_AMD64_PERF_CNTR_GLOBAL_STATUS_SET.
My bad. Since MSR_CORE_PERF_GLOBAL_STATUS_SET already rejects non-zero
reserved bits, thus 'data & ~pmu->global_status_rsvd` is an effective
no-op for Intel.
I'll update it for v5:
--- a/arch/x86/kvm/pmu.c
+++ b/arch/x86/kvm/pmu.c
@@ -938,10 +938,8 @@ int kvm_pmu_set_msr(struct kvm_vcpu *vcpu, struct
msr_data *msr_info)
break;
case MSR_CORE_PERF_GLOBAL_STATUS_SET:
if (data & pmu->global_status_rsvd)
return 1;
- if (!msr_info->host_initiated)
- pmu->global_status |= data;
- break;
+ fallthrough;
case MSR_AMD64_PERF_CNTR_GLOBAL_STATUS_SET:
if (!msr_info->host_initiated)
pmu->global_status |= data &
~pmu->global_status_rsvd;