Re: [PATCH net-next v4 03/10] dt-bindings: net: qcom,ethqos: add qcom,shikra-ethqos compatible

From: Rob Herring

Date: Wed Nov 18 2026 - 14:08:01 EST


On Tue, Nov 17, 2026 at 02:15:23PM +0530, Mohd Ayaan Anwar wrote:
> Shikra's EMAC requires two additional clocks for NOC interconnect
> access (axi-noc, pcie-tile-axi-noc) beyond the standard four, and an
> OPP table with required-opps to vote VDD_CX to SVS when the NOC clocks
> are enabled.
>
> Add qcom,shikra-ethqos to the compatible enum and use an if/else
> block to constrain Shikra to exactly six clocks and require
> operating-points-v2 and power-domains, while leaving existing
> compatibles unchanged.
>
> Add the relevant compatible to the binding document for snps,dwmac as
> well.
>
> Signed-off-by: Mohd Ayaan Anwar <mohd.anwar@xxxxxxxxxxxxxxxx>
> ---
> v4: moved operating-points description to the top-level, and added
> power-domains as a required property for Shikra.
> ---
> .../devicetree/bindings/net/qcom,ethqos.yaml | 54 ++++++++++++++++++++--
> .../devicetree/bindings/net/snps,dwmac.yaml | 2 +
> 2 files changed, 52 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> index ef520f810577..6bd4bded650a 100644
> --- a/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> +++ b/Documentation/devicetree/bindings/net/qcom,ethqos.yaml
> @@ -14,9 +14,6 @@ description:
> dwmmac based Qualcomm ethernet devices which support Gigabit
> ethernet (version v2.3.0 and onwards).
>
> -allOf:
> - - $ref: snps,dwmac.yaml#
> -
> properties:
> compatible:
> oneOf:
> @@ -32,6 +29,7 @@ properties:
> - qcom,qcs404-ethqos
> - qcom,sa8775p-ethqos
> - qcom,sc8280xp-ethqos
> + - qcom,shikra-ethqos
> - qcom,sm8150-ethqos
>
> reg:
> @@ -57,9 +55,11 @@ properties:
> - const: sfty
>
> clocks:
> - maxItems: 4
> + minItems: 4
> + maxItems: 6
>
> clock-names:
> + minItems: 4
> items:
> - const: stmmaceth
> - const: pclk
> @@ -67,6 +67,8 @@ properties:
> - enum:
> - rgmii
> - phyaux
> + - const: axi-noc
> + - const: pcie-tile-axi-noc

These sound like inter-connect clocks. Shouldn't they be controlled by
a interconnect driver?

>
> iommus:
> maxItems: 1
> @@ -81,6 +83,14 @@ properties:
> - const: cpu-mac
> - const: mac-mem
>
> + operating-points-v2:
> + description: |
> + For Shikra, the OPP table specifies the rates for the NOC access
> + clocks in "stmmaceth", "axi-noc", "pcie-tile-axi-noc" order.
> +
> + opp-table:
> + type: object
> +
> phys: true
>
> phy-names:
> @@ -95,6 +105,42 @@ required:
> - clock-names
> - reg-names
>
> +allOf:
> + - $ref: snps,dwmac.yaml#
> +
> + - if:
> + properties:
> + compatible:
> + contains:
> + const: qcom,shikra-ethqos
> + then:
> + properties:
> + clocks:
> + minItems: 6
> + clock-names:
> + items:
> + - const: stmmaceth
> + - const: pclk
> + - const: ptp_ref
> + - const: rgmii
> + - const: axi-noc
> + - const: pcie-tile-axi-noc

No need to repeat the names here. Just 'minItems: 6'. I suppose you
might also want:

contains:
const: rgmii

> + required:
> + - operating-points-v2
> + - power-domains
> + else:
> + properties:
> + clocks:
> + maxItems: 4
> + clock-names:
> + items:
> + - const: stmmaceth
> + - const: pclk
> + - const: ptp_ref
> + - enum:
> + - rgmii
> + - phyaux

Just 'minItems: 4'

Rob