Re: [PATCH 2/3] wifi: wcn36xx: Do not enforce interrupt trigger type
From: Loic Poulain
Date: Wed Nov 18 2026 - 15:21:23 EST
On Wed, Nov 18, 2026 at 3:58 PM Alexandre Rapaille via B4 Relay
<devnull+arapaille.atlr-engineering.com@xxxxxxxxxx> wrote:
>
> From: Alexandre Rapaille <arapaille@xxxxxxxxxxxxxxxxxxxx>
>
> Forcing IRQF_TRIGGER_HIGH over the DT type makes the re-probe after a WCNSS
> restart fail ("type mismatch, failed to map hwirq"). Rely on the DT, as
> commit 1ee6c5abebd3 ("ath10k: do not enforce interrupt trigger type") did.
Can you explain why it fails? Is the fix at the right layer here?
>
> Fixes: 8e84c2582169 ("wcn36xx: mac80211 driver for Qualcomm WCN3660/WCN3680 hardware")
> Signed-off-by: Alexandre Rapaille <arapaille@xxxxxxxxxxxxxxxxxxxx>
> ---
> drivers/net/wireless/ath/wcn36xx/dxe.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/wireless/ath/wcn36xx/dxe.c b/drivers/net/wireless/ath/wcn36xx/dxe.c
> index 801f1218ef..7852f71368 100644
> --- a/drivers/net/wireless/ath/wcn36xx/dxe.c
> +++ b/drivers/net/wireless/ath/wcn36xx/dxe.c
> @@ -552,14 +552,14 @@ static int wcn36xx_dxe_request_irqs(struct wcn36xx *wcn)
> {
> int ret;
>
> - ret = request_irq(wcn->tx_irq, wcn36xx_irq_tx_complete,
> - IRQF_TRIGGER_HIGH, "wcn36xx_tx", wcn);
> + ret = request_irq(wcn->tx_irq, wcn36xx_irq_tx_complete, 0,
> + "wcn36xx_tx", wcn);
> if (ret) {
> wcn36xx_err("failed to alloc tx irq\n");
> goto out_err;
> }
>
> - ret = request_irq(wcn->rx_irq, wcn36xx_irq_rx_ready, IRQF_TRIGGER_HIGH,
> + ret = request_irq(wcn->rx_irq, wcn36xx_irq_rx_ready, 0,
> "wcn36xx_rx", wcn);
> if (ret) {
> wcn36xx_err("failed to alloc rx irq\n");
>
> --
> 2.43.0
>
>