[PATCH v6 3/8] media: tw9900: add saturation, hue and sharpness controls
From: Matthew Laux
Date: Wed Nov 18 2026 - 15:43:48 EST
Add additional V4L2 controls for the tw9900 that modify the appropriate
registers for saturation, hue, and sharpness, sourced from the datasheet.
Signed-off-by: Matthew Laux <matthew.laux@xxxxxxxxx>
---
drivers/media/i2c/tw9900.c | 33 ++++++++++++++++++++++++++++++++-
1 file changed, 32 insertions(+), 1 deletion(-)
diff --git a/drivers/media/i2c/tw9900.c b/drivers/media/i2c/tw9900.c
index 60d5686716f7..d365432e8f89 100644
--- a/drivers/media/i2c/tw9900.c
+++ b/drivers/media/i2c/tw9900.c
@@ -41,6 +41,11 @@
#define TW9900_REG_CNTRL1 0x0C
#define TW9900_REG_BRIGHT_CTL 0x10
#define TW9900_REG_CONTRAST_CTL 0x11
+#define TW9900_REG_SHARPNESS 0x12
+#define TW9900_REG_SHARPNESS_MASK GENMASK(3, 0)
+#define TW9900_REG_SAT_U 0x13
+#define TW9900_REG_SAT_V 0x14
+#define TW9900_REG_HUE 0x15
#define TW9900_REG_VBI_CNTL 0x19
#define TW9900_REG_ANAL_CTL_II 0x1A
#define TW9900_REG_OUT_CTRL_II 0x1B
@@ -252,6 +257,26 @@ static int tw9900_s_ctrl(struct v4l2_ctrl *ctrl)
ret = tw9900_write_reg(tw9900->client, TW9900_REG_CONTRAST_CTL,
(u8)ctrl->val);
break;
+ case V4L2_CID_SATURATION:
+ ret = tw9900_write_reg(tw9900->client, TW9900_REG_SAT_U,
+ (u8)ctrl->val);
+ if (ret)
+ break;
+ ret = tw9900_write_reg(tw9900->client, TW9900_REG_SAT_V,
+ (u8)ctrl->val);
+ break;
+ case V4L2_CID_HUE:
+ ret = tw9900_write_reg(tw9900->client, TW9900_REG_HUE,
+ (u8)ctrl->val);
+ break;
+ case V4L2_CID_SHARPNESS:
+ ret = tw9900_read_reg(tw9900->client, TW9900_REG_SHARPNESS);
+ if (ret < 0)
+ break;
+ ret = tw9900_write_reg(tw9900->client, TW9900_REG_SHARPNESS,
+ (ret & ~TW9900_REG_SHARPNESS_MASK) |
+ ctrl->val);
+ break;
default:
ret = -EINVAL;
break;
@@ -701,7 +726,7 @@ static int tw9900_probe(struct i2c_client *client)
hdl = &tw9900->hdl;
- ret = v4l2_ctrl_handler_init(hdl, 2);
+ ret = v4l2_ctrl_handler_init(hdl, 5);
if (ret)
goto err_destory_mutex;
@@ -711,6 +736,12 @@ static int tw9900_probe(struct i2c_client *client)
-128, 127, 1, 0);
v4l2_ctrl_new_std(hdl, &tw9900_ctrl_ops, V4L2_CID_CONTRAST,
0, 255, 1, 0x60);
+ v4l2_ctrl_new_std(hdl, &tw9900_ctrl_ops, V4L2_CID_SATURATION,
+ 0, 255, 1, 0x80);
+ v4l2_ctrl_new_std(hdl, &tw9900_ctrl_ops, V4L2_CID_HUE,
+ -128, 127, 1, 0);
+ v4l2_ctrl_new_std(hdl, &tw9900_ctrl_ops, V4L2_CID_SHARPNESS,
+ 0, 15, 1, 1);
tw9900->subdev.ctrl_handler = hdl;
if (hdl->error) {
--
2.47.3