Re: [PATCH net 5/7] mptcp: push queued data on subflows falling back at the handshake
From: Matthieu Baerts
Date: Wed Nov 18 2026 - 17:02:48 EST
Hello,
On 17/11/2026 23:29, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
>
> Low priority / nit picks for your consideration:
(...)
> [Severity: Low]
> Can this push also run while an incoming RST is being processed?
This is not new: the fallback block at the top of mptcp_incoming_options
already does the same push, RST or not. At worst, data is queued then
purged, or sent within the TCP window just before the reset, and the
peer replies with a reset. This is harmless. If really needed (I don't
think so) a follow-up patch can be sent, but to -next I suppose.
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.