Re: [PATCH net 4/7] mptcp: push queued data on passive TFO subflows becoming established

From: Matthieu Baerts

Date: Wed Nov 18 2026 - 17:03:09 EST


Hello,

On 17/11/2026 23:29, netdev-bot+sashiko@xxxxxxxxxx wrote:
> Thank you for your contribution! Sashiko AI review found more severe
> issue(s) in other patches of this series. This mail is only an FYI, in case
> you want to address the nit picks below when you respin.
>
> Low priority / nit picks for your consideration:

(...)

>> Without this patch, and before the
>> earlier commit "mptcp: arm the rtx timer if a push leaves data behind",
>> this data was not sent:
>>
>> server-tfo-write-before-3rd-ack.pkt:24: error handling packet: Timed out waiting for packet
>>
>> Since this earlier commit, this data is sent, but only when the MPTCP
>> retransmission timer fires, here after one second, as the tests increase
>> its interval:
>
> [Severity: Low]
> Which tree is "mptcp: arm the rtx timer if a push leaves data behind" in?

Arf, I forgot to remove that when I cherry-picked this fix. That's a
detail, it's a fix pending on the MPTCP ML, not applied yet:


https://lore.kernel.org/20261113-mptcp-cmason-fixes-v1-7-9205b77e9a2f@xxxxxxxxxx

There is no dependency: in this tree, the data was never sent, as
described for the case "before this earlier commit". I suggest ignoring
that, it's not directly linked, and this patch will come soon.

Cheers,
Matt
--
Sponsored by the NGI0 Core fund.