Re: [PATCH v2] mm/userfaultfd: check exclusivity of the page being moved

From: Jose A. Perez de Azpillaga

Date: Wed Nov 18 2026 - 18:46:17 EST


On 11/17/26 10:24 PM, Eric Li wrote:
> move_pages_ptes() gets the folio of a present source PTE and then checks
> PageAnonExclusive() on the first page of that folio. PG_anon_exclusive
> is per page, so for a PTE-mapped large folio this can give the wrong
> answer for the page that is actually being moved.
>
> This happens after fork(). fork() clears the flag on every page of the
> folio. Once the child exits, a write fault in the parent can reuse the
> large folio, and do_wp_page() sets the flag again only on the faulting
> page. This case only exists since commit 1da190f4d0a6 ("mm:
> Copy-on-Write (COW) reuse support for PTE-mapped THP"). Before that,
> the same state could already come from fork() after MADV_DONTFORK on
> part of the folio, or from reclaim when try_to_unmap() replaces the
> earlier pages with swap entries and then fails on a later one.
>
> Moving that page with UFFDIO_MOVE then fails with -EBUSY, even though
> the folio could be split and the page moved. Callers that fall back to
> UFFDIO_COPY on -EBUSY end up copying instead. It also goes wrong the
> other way: if the first page is exclusive and the page being moved is
> not, the folio is split for nothing before the retry sees the shared
> page and returns -EBUSY.
>
> Check the flag on the page mapped by the source PTE and get the folio
> from that page. Locking, refcounting and the split-and-retry path stay
> the same. The batched path only handles small folios and the PMD path
> already checks the page the PMD maps, so they don't need this.
>
> Tested in an x86_64 KVM guest on mm-unstable with only 64K anonymous
> mTHP enabled: map a 64K-aligned region backed by one large folio, fork,
> let the child exit, write to the sixth page and move it. Without this
> patch all 20 moves failed with -EBUSY. With it all 20 worked and the
> data was correct. Moving the first page right after fork() still fails
> with -EBUSY, as it should. Writing to the first page instead and moving
> the sixth fails with -EBUSY either way, but without this patch the folio
> was also split all 20 times. The move tests in uffd-unit-tests pass
> with and without the patch (the two swap tests were skipped, there is
> no swap in the guest). I didn't reproduce the MADV_DONTFORK or reclaim
> cases and didn't test arm64.
>
> I found this with Claude Code while debugging an out-of-tree swap
> backend, and it wrote the first version of the fix. This version, the
> changelog and the reproducer were also done with AI help. I've reviewed
> all of it.
>
> Fixes: adef440691ba ("userfaultfd: UFFDIO_MOVE uABI")
> Link: https://lore.kernel.org/all/20261116110122.309748-1-nakixii@xxxxxxxxx/
> Acked-by: Mike Rapoport (Microsoft) <rppt@xxxxxxxxxx>
> Signed-off-by: Eric Li <nakixii@xxxxxxxxx>

LGTM:

Reviewed-by: Jose A. Perez de Azpillaga <azpijr@xxxxxxxxx>

--
cheers,
jose a. p-a