Re: [PATCH v3 0/6] PCI/DPC: Decide DPC ownership with host_bridge->native_dpc

From: Bjorn Helgaas

Date: Wed Nov 18 2026 - 19:11:15 EST


On Wed, Nov 18, 2026 at 10:17:12AM -0800, Kuppuswamy Sathyanarayanan wrote:
> This series makes host_bridge->native_dpc the single decider for whether
> Linux uses DPC, as Bjorn asked during the review of "Simplify PCIe native
> ownership".
>
> https://lore.kernel.org/r/20261001221408.GA2731929@bhelgaas
>
> Today the DPC service binds on host_bridge->native_aer, AER availability
> and "pcie_ports=dpc-native". host_bridge->native_dpc is only consulted
> by pci_dpc_recovered(). After this series, native_dpc is the end result
> of everything that decides DPC ownership, and portdrv binds the DPC
> service on it.
>
> Patches 1-2 are the two DPC patches from v2 of Lukas's "Error reporting
> for AER-incapable devices", which are included here directly.
>
> https://lore.kernel.org/r/34c9ee153876bac953135b4518035194b7c07c6c.1794997749.git.lukas@xxxxxxxxx
> https://lore.kernel.org/r/58d8a99cc6c2ecba6dadc450ecb4501d47816732.1794997749.git.lukas@xxxxxxxxx
>
> Patch 1 keeps the DPC driver from accessing a non-existent AER
> capability.
>
> Patch 2 drops the AER ownership check from dpc_probe(), so DPC also
> works on ports without an AER capability.
>
> Patch 3 builds EDR whenever DPC is enabled on ACPI, so CONFIG_PCIE_EDR
> is no longer a separate knob in deciding whether to request DPC control.
>
> Patch 4 stops requiring pci_aer_available() to bind the DPC service,
> since the DPC driver does not depend on MSI or on the AER driver.
>
> Patch 5 requests DPC control only together with AER control, as PCI
> Firmware r3.3, sec 4.5.2.4, requires.
>
> Patch 6 binds the DPC service on host_bridge->native_dpc and logs a
> message when the OS assumes DPC control that _OSC did not grant.
>
> Changes since v2:
>
> - Pick up v2 of Lukas's two DPC patches. Patch 1 now uses the AER
> capability to find the error severity when the port has one.
>
> - Keep CONFIG_PCIE_EDR as a hidden option instead of removing it, and
> remove the pci_dpc_recovered() check that becomes dead (Yazen).
>
> - Fold the PCI Firmware spec reference into the existing comment in
> calculate_control() (Yazen).
>
> - Shorten the comment in acpi_pci_root_create() (Yazen).
>
> - Rebase on v7.4-rc1 and add Reviewed-by and Acked-by tags.
>
> v2: https://lore.kernel.org/r/20261020181924.3003553-1-sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx
> v1: https://lore.kernel.org/r/20261007165840.1604136-1-sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx
>
> Kuppuswamy Sathyanarayanan (4):
> PCI/EDR: Build EDR whenever DPC is enabled on ACPI
> PCI/portdrv: Don't require AER to bind DPC service
> PCI/ACPI: Request DPC control only together with AER control
> PCI/portdrv: Bind DPC service based on host_bridge->native_dpc
>
> Lukas Wunner (2):
> PCI/DPC: Avoid access to non-existent AER capability
> PCI/DPC: Reinstate support for AER-incapable ports
>
> drivers/acpi/pci_root.c | 19 +++++++++++--
> drivers/pci/pcie/Kconfig | 8 +-----
> drivers/pci/pcie/dpc.c | 58 +++++++++++++++++++++-----------------
> drivers/pci/pcie/portdrv.c | 7 +----
> 4 files changed, 51 insertions(+), 41 deletions(-)

Applied to pci/aer for v7.5, thank you!

B4 seems to collect historical things, e.g., Yazen's reviewed-by and
another Fixes: tag on "PCI/DPC: Reinstate support for AER-incapable
ports". I *guess* that's all great, but I didn't dig out where they
originally came from. I don't see them in the v3 thread on lore
(https://lore.kernel.org/all/20261118181718.3907441-1-sathyanarayanan.kuppuswamy@xxxxxxxxxxxxxxx/),
so they must be from a previous posting.