Re: [PATCH net-next v2 4/4] net: mdio: mdio-bcm-unimac: Add Clause 45 support
From: Florian Fainelli
Date: Wed Nov 18 2026 - 19:53:48 EST
On 11/18/26 16:37, netdev-bot+sashiko@xxxxxxxxxx wrote:
Thank you for your contribution! Sashiko AI review found 5 potential
issue(s) to consider.
Critical: 0 · High: 0 · Medium: 2 · Low: 3
If you believe none of the issues are legitimate, please reply to each
issue of Medium severity or higher and explain why the AI is wrong.
If any of them are legitimate and you plan to respin, please let patchwork
know by including "pw-bot: cr" as a separate line at the end of your reply
(one such reply per series is enough).
- [Medium] The new C45 sequence issues an ADDR frame followed by a
READ/WRITE frame through MDIO_CMD.
This was a real problem for wait_func implementations that return 0 without the controller being idle (bcmgenet_mii_wait()). It is fixed in the next version: unimac_mdio_addr_c45() now polls MDIO_CMD for START_BUSY to clear after wait_func returns, so the READ/WRITE frame is never started while the ADDR frame is still on the wire.
- [Medium] unimac_mdio_set_clause() (mdio-bcm-unimac.c:126-138) adds a
read-modify-write of MDIO_CFG to the MDIO access path, and that RMW is…
Also valid, and fixed in the next version: unimac_mdio_resume() now takes bus->mdio_lock around unimac_mdio_clk_set(), so the two MDIO_CFG read-modify-writes are serialized.
- [Low] This patch changes behaviour for existing users of the non-DT
(ACPI) GENET path more than the commit message says.
The C45 scan does run there, since that instance does not mask any address. It only probes addresses that have no C22 device, so it cannot take the place of the C22 PHY that phy_find_first() returns on those systems. The commit message now says so. The scan is also cheaper than it was, since patch 1 now stops after a failing MMD and goes straight to the MMD 0 probe.
- [Low] The comment above MDIO_POLL_DELAY_US/MDIO_POLL_TIMEOUT_US (mdio-
bcm-unimac.c:45-48: 'A C45 access is two frames, so a 1ms timeout…
Reworded in the next version, along with the comment in unimac_mdio_poll(), to say that the timeout applies to each frame.
- [Low] The driver now enables C45 on every controller it binds.
AFAICT, all controller HW support C45 and have the definitions for the bits we are using.
pw-bot: cr
--
Florian