Re: [PATCH net-next v2 0/9] dpll: do not serialize driver callbacks under global dpll_lock
From: Jakub Kicinski
Date: Wed Nov 18 2026 - 20:44:30 EST
On Wed, 18 Nov 2026 16:29:23 +0100 Ivan Vecera wrote:
> A step of the zl3073x PHC, which ptp4l and ts2phc do at start and after
> a large offset, waits for the next 1 PPS edge, up to 1 s, with the
> channel lock held. A phase step can hold it for up to 3 s while it
> waits for the previous one. A dpll callback of that channel waits for
> the lock under dpll_lock, and every other DPLL request and notification
> in the system waits behind it. With ToD writes running, requests to an
> ice DPLL took 1448 ms in median and 3.9 s at most. With the series they
> took 0.2 ms and 0.3 ms, the same as idle.
>
> The bigger reason are zl3073x callbacks we are working on, which have
> to wait for the hardware themselves:
>
> - a device reset with resync waits for the fast lock, up to 1 s with a
> 1 PPS input
> - a glitchless stop or start of an output completes on an output edge,
> so it takes up to one period, 1 s for a 1 PPS output
>
> Holding the global dpll_lock for that long would stall every DPLL
> device in the system. For the output state we tried an asynchronous
> implementation, but then the callback returns success before it knows
> the result.
Right, for these level of waiting async seems like the right direction,
at least naively/without knowing the HW. Why does the device wait until
PPS to apply the step change? Is the programmed time supposed to
correspond to the pulse?
> A failure can only be reported by a later notification, and
> the next request gets -EBUSY until the change completes. With a lock
> per chip the callback can simply wait, and one chip cannot do these
> operations in parallel anyway.
Do the failures only happen because of "unforeseen circumstances" / EIO,
or there may be more common errors reported? If it's just the former
a devlink health reporter could be an option.