[PATCH] ACPI: GED: Add wake support for wake-capable interrupts
From: Rui Qi
Date: Wed Nov 18 2026 - 21:23:56 EST
GED interrupt resources can be marked wake-capable by firmware, but the
GED driver does not enable IRQ wake for them. Consequently, the generic
IRQ suspend code disables those interrupts along with ordinary device
IRQs, preventing them from waking a system in suspend-to-idle.
Enable IRQ wake after registering each interrupt whose resource has
IORESOURCE_IRQ_WAKECAPABLE set. Remember successful enables per event
so that releasing the event disables IRQ wake before freeing the IRQ.
This supports multiple wake interrupts on one GED without relying on
the single wake IRQ slot in struct device.
Keep runtime event handling available if enabling IRQ wake fails, and
warn about the missing wake functionality. Release previously registered
events when walking _CRS fails, balancing both IRQ registrations and wake
references before device-managed event storage is released.
This does not implement device _PRW-to-GED mappings or infer wake
capability for interrupt resources not marked wake-capable by firmware.
Fixes: 3db80c230da1 ("ACPI: implement Generic Event Device")
Signed-off-by: Rui Qi <qirui.001@xxxxxxxxxxxxx>
---
drivers/acpi/evged.c | 34 +++++++++++++++++++++++++++-------
1 file changed, 27 insertions(+), 7 deletions(-)
diff --git a/drivers/acpi/evged.c b/drivers/acpi/evged.c
index 189dc68b8875..8afae44ac2b3 100644
--- a/drivers/acpi/evged.c
+++ b/drivers/acpi/evged.c
@@ -51,6 +51,7 @@ struct acpi_ged_event {
unsigned int gsi;
unsigned int irq;
acpi_handle handle;
+ bool wake_enabled;
};
static irqreturn_t acpi_ged_irq_handler(int irq, void *data)
@@ -81,6 +82,7 @@ static acpi_status acpi_ged_request_interrupt(struct acpi_resource *ares,
struct acpi_resource_extended_irq *pext = &ares->data.extended_irq;
char ev_name[5];
u8 trigger;
+ int ret;
if (ares->type == ACPI_RESOURCE_TYPE_END_TAG)
return AE_OK;
@@ -133,11 +135,34 @@ static acpi_status acpi_ged_request_interrupt(struct acpi_resource *ares,
return AE_ERROR;
}
+ if (r.flags & IORESOURCE_IRQ_WAKECAPABLE) {
+ ret = enable_irq_wake(irq);
+ if (ret)
+ dev_warn(dev, "failed to enable wakeup for irq %u: %d\n",
+ irq, ret);
+ else
+ event->wake_enabled = true;
+ }
+
dev_dbg(dev, "GED listening GSI %u @ IRQ %u\n", gsi, irq);
list_add_tail(&event->node, &geddev->event_list);
return AE_OK;
}
+static void ged_release_events(struct acpi_ged_device *geddev)
+{
+ struct acpi_ged_event *event, *next;
+
+ list_for_each_entry_safe(event, next, &geddev->event_list, node) {
+ if (event->wake_enabled)
+ disable_irq_wake(event->irq);
+ free_irq(event->irq, event);
+ list_del(&event->node);
+ dev_dbg(geddev->dev, "GED releasing GSI %u @ IRQ %u\n",
+ event->gsi, event->irq);
+ }
+}
+
static int ged_probe(struct platform_device *pdev)
{
struct acpi_ged_device *geddev;
@@ -153,6 +178,7 @@ static int ged_probe(struct platform_device *pdev)
acpi_ged_request_interrupt, geddev);
if (ACPI_FAILURE(acpi_ret)) {
dev_err(&pdev->dev, "unable to parse the _CRS record\n");
+ ged_release_events(geddev);
return -EINVAL;
}
platform_set_drvdata(pdev, geddev);
@@ -163,14 +189,8 @@ static int ged_probe(struct platform_device *pdev)
static void ged_shutdown(struct platform_device *pdev)
{
struct acpi_ged_device *geddev = platform_get_drvdata(pdev);
- struct acpi_ged_event *event, *next;
- list_for_each_entry_safe(event, next, &geddev->event_list, node) {
- free_irq(event->irq, event);
- list_del(&event->node);
- dev_dbg(geddev->dev, "GED releasing GSI %u @ IRQ %u\n",
- event->gsi, event->irq);
- }
+ ged_release_events(geddev);
}
static void ged_remove(struct platform_device *pdev)
--
2.20.1