Re: [PATCH v1 4/5] dt-bindings: iio: adc: Add ADA4355
From: Jonathan Cameron
Date: Wed Nov 18 2026 - 22:00:09 EST
On Wed, 18 Nov 2026 17:39:46 +0000
Conor Dooley <conor@xxxxxxxxxx> wrote:
> On Wed, Nov 18, 2026 at 10:04:13AM -0300, Marcelo Schmitt wrote:
> > The ADA4355 is an integrated analog front-end and 14-bit analog-to-digital
> > converter with a serial LVDS data interface.
> >
> > Document how to describe ADA4355 devices in device tree.
>
> Please explain why the 4356 differs rom the 4355 such that it cannot use
> a fallback compatible.
Also mention it in the patch description!
I was briefly very confused at Conor's comment :)
>
> Thanks,
> Conor.
> pw-bot: changes-requested
> >
> > Signed-off-by: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> > ---
> > .../bindings/iio/adc/adi,ada4355.yaml | 104 ++++++++++++++++++
> > MAINTAINERS | 7 ++
> > 2 files changed, 111 insertions(+)
> > create mode 100644 Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml
> > new file mode 100644
> > index 000000000000..d169619fef25
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml
> > @@ -0,0 +1,104 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/iio/adc/adi,ada4355.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices Transimpedance Current to Bits Receiver
> > +
> > +maintainers:
> > + - Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> > +
> > +description: |
> > + ADA4355 programmable transimpedance, current to bits receiver and similar data
> > + converters.
> > + Specifications can be found at:
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/ada4355.pdf
> > + https://www.analog.com/media/en/technical-documentation/data-sheets/ada4356.pdf
> > +
> > +$ref: /schemas/spi/spi-peripheral-props.yaml#
> > +
> > +properties:
> > + compatible:
> > + enum:
> > + - adi,ada4355
> > + - adi,ada4356
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + spi-max-frequency:
> > + maximum: 50000000
> > +
> > + spi-3wire: true
> > +
> > + spi-cpha: true
> > +
> > + vcc-supply:
> > + description: 3.3V power supply.
> > +
> > + vea-supply:
> > + description: 1.8V analog power supply to ADC.
> > +
> > + ved-supply:
> > + description: 1.8V digital power supply to ADC.
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > + adi,vld-en-gpios:
> > + description: GPIO connected to the VLDEN pin for VLD output enable.
> > +
> > + adi,gsel-gpios:
> > + description:
> > + GPIOs connected to the GSEL0 and GSEL1 pins, in that order, for
> > + transimpedance gain selection.
> > + minItems: 2
> > + maxItems: 2
> > +
> > + adi,lfp-gpios:
> > + description:
> > + GPIO connected to FSEL for internal low pass filter bandwidth selection.
> > +
> > + io-backends:
> > + description:
> > + The AXI ADC IP block connected to the D+/- and DCO+/- lines of the
> > + ADC. An example backend can be found at
> > + http://analogdevicesinc.github.io/hdl/projects/pulsar_lvds/index.html.
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - vcc-supply
> > + - spi-3wire
> > + - spi-cpha
> > + - clocks
> > + - adi,vld-en-gpios
> > + - adi,gsel-gpios
> > + - adi,lfp-gpios
> > +
> > +unevaluatedProperties: false
> > +
> > +examples:
> > + - |
> > + #include <dt-bindings/gpio/gpio.h>
> > + spi {
> > + #address-cells = <1>;
> > + #size-cells = <0>;
> > +
> > + adc@0 {
> > + compatible = "adi,ada4355";
> > + reg = <0>;
> > + spi-max-frequency = <100000>;
> > + spi-3wire;
> > + spi-cpha;
> > + vcc-supply = <&supply_3_3V>;
> > + clocks = <&ref_clk>;
> > + adi,vld-en-gpios = <&gpio0 89 GPIO_ACTIVE_HIGH>;
> > + adi,gsel-gpios = <&gpio0 86 GPIO_ACTIVE_HIGH>,
> > + <&gpio0 87 GPIO_ACTIVE_HIGH>;
> > + adi,lfp-gpios = <&gpio0 88 GPIO_ACTIVE_HIGH>;
> > + io-backends = <&axi_adc>;
> > + };
> > + };
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 02015eaec312..692f1e6d56ec 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -1794,6 +1794,13 @@ W: https://ez.analog.com/linux-software-drivers
> > F: Documentation/devicetree/bindings/iio/amplifiers/adi,ada4250.yaml
> > F: drivers/iio/amplifiers/ada4250.c
> >
> > +ANALOG DEVICES INC ADA4355 DRIVER
> > +M: Marcelo Schmitt <marcelo.schmitt@xxxxxxxxxx>
> > +L: linux-iio@xxxxxxxxxxxxxxx
> > +S: Supported
> > +W: https://ez.analog.com/linux-software-drivers
> > +F: Documentation/devicetree/bindings/iio/adc/adi,ada4355.yaml
> > +
> > ANALOG DEVICES INC ADE9000 DRIVER
> > M: Antoniu Miclaus <antoniu.miclaus@xxxxxxxxxx>
> > L: linux-iio@xxxxxxxxxxxxxxx
> > --
> > 2.39.2
> >