Re: [PATCH] block: Fix NULL pointer dereference in blk_mq_complete_request_remote

From: Srivatsa S. Bhat

Date: Wed Nov 18 2026 - 22:34:56 EST


On Wed, Nov 18, 2026 at 01:12:42PM -0700, Jens Axboe wrote:
> On 11/18/26 12:28 PM, Srivatsa S. Bhat (Microsoft) wrote:
> > Add NULL pointer validation in blk_mq_complete_request_remote() to
> > prevent kernel crashes when block drivers pass freed request structures.
>
> Please stop this nonsense.
>

Thank you for the feedback, Jens! And thanks to Hamza and Keith for
their review, which helped me understand what the pushback was about.
I've now clarified about the underlying firmware bug being fixed (in
my other reply), which I had failed to mention earlier when I reported
that the crash isn't reproducible any more. My bad - I can see how
that (unintentional) omission made it look like I'm adding a
workaround in the kernel for a bug that exists somewhere else
altogether.

Thank you!

Regards,
Srivatsa