[PATCH v4 0/8] drm/rockchip: vop2: RK3588 clocking, sync polarity and window fixes
From: Arun Iyengar via B4 Relay
Date: Thu Nov 19 2026 - 00:22:03 EST
Fixes for the RK3588 VOP2 found while bringing up HDMI and DisplayPort
on an Orange Pi 5 (RK3588S).
Tested on an Orange Pi 5 with an HDMI 2.1 TV and a DisplayPort monitor,
pictures judged with a camera, v7.3 based kernel: VP_CLK_CTRL reads back
without the garbage divider; the HDMI controller sees the sync polarities
of +/+ and mixed modes; HDMI from 148.5 to 1188 MHz (TMDS and FRL) and DP
show a correct picture; RGB565 on the Cluster windows scans out without
YTR; NV12 in two GEM objects and an AFBC overlay at x=1001 show correctly.
Not tested: -HSync/-VSync modes (none in the TV's list), BGR565, HDMI1,
eDP, MIPI DSI and DPI (no hardware).
Developed with Claude (Anthropic), which wrote the code and the commit
messages. I reviewed every change.
Signed-off-by: Arun Iyengar <aiyengar1990@xxxxxxxxx>
---
Changes in v4:
- Patches 1 and 2: Reviewed-by added (Damon Ding).
- Patch 4: the GRF sync polarity bits get names in rockchip_drm_vop2.h
(Damon Ding); comment dropped.
- Patch 5: check moved after the 10bpc check, with a comment and a
drm_dbg_kms() (Damon Ding); it tests drm_is_afbc() there, as it now
runs before the linear return.
- Rebased on drm-misc-next.
- Link to v3: https://patch.msgid.link/20261113-vop2-fixes-v3-0-08ae37e83b5c@xxxxxxxxx
---
Arun Iyengar (8):
drm/rockchip: vop2: Take the UV plane address from the second GEM object
drm/rockchip: vop2: Don't use uninitialised dividers on RK3588
drm/rockchip: vop2: Fix the HDMI sync polarity on RK3588
drm/rockchip: vop2: Fix the HDMI sync polarity bit order on RK3588
drm/rockchip: vop2: Only accept AFBC YTR for 8 bit RGB on RK3588
drm/rockchip: vop2: Find the first mixer of a video port with Esmart3 too
drm/rockchip: vop2: Keep the other LUT_PORT_SEL fields on gamma LUT updates
drm/rockchip: vop2: Fix the AFBC offsets of a source that starts inside a superblock
drivers/gpu/drm/rockchip/rockchip_drm_vop2.c | 27 +++++++++++++++++++--------
drivers/gpu/drm/rockchip/rockchip_drm_vop2.h | 3 +++
drivers/gpu/drm/rockchip/rockchip_vop2_reg.c | 16 ++++++++++++----
3 files changed, 34 insertions(+), 12 deletions(-)
---
base-commit: fac7a5f16230779cfb0d50ca49e9467cc94a2ea9
change-id: 20261110-vop2-fixes-fa45142799c1
Best regards,
--
Arun Iyengar <aiyengar1990@xxxxxxxxx>