Re: [PATCH net-next v10 11/12] net: dsa: realtek: rtl8365mb: make L2/LUT access work on family D
From: Mieczyslaw Nalewaj
Date: Thu Nov 19 2026 - 01:21:42 EST
Hi,
A follow-up to my reply about point 1 (a private FID for the offloaded
bridge). I could not confirm it from the vendor API and said it needed
hardware experiments. Gustavo Foletto Mora has now measured it on an
RTL8367S-VB (EX511) with a development version that wrote FID 1 into the
VLAN 4K entries of the bridge and used it in the FDB/MDB keys.
What the measurement showed:
- The chip learns with the FID of the 4K entry the frame is classified
into (IVL_EN=0), and static entries written with that FID replace the
learned ones.
- Standalone ports (PVID 0) do not land in that FID, so for a bridge
whose ports have a PVID the collision is gone.
Why I still won’t do this in the next series:
- The FID comes only from a VLAN 4K entry. The default OpenWrt br-lan has
no VLAN: its ports keep PVID 0, the driver writes no 4K entry for
VID 0, and the bridge is looked up in FID 0, while the entries are
written with FID 1. The keys then never match: a static entry no longer
steers or drops (104 frames out of the uplink for 100 sent, 7 with the
shared FID 0).
- With fdb_isolation, DSA installs the standalone ports' addresses as host
entries in FID 0, which the plain bridge also looks up. Its frames to
them go to the CPU with offload_fwd_mark set and are not forwarded by
the software bridge: 0/50 on h1 -> h2, versus 50/50 with the shared FID.
So a private FID fixes the case with a PVID and breaks the more common
one, which is worse than the documented limitation. The next revision
will keep the shared FID 0 and the limitation as described in the commit
message.
A complete solution would give the ports of a VLAN-unaware bridge a
private PVID whose 4K entry carries the bridge FID, as mv88e6xxx does
(MV88E6XXX_VID_BRIDGED / MV88E6XXX_FID_BRIDGED). That needs the PVID to
follow vlan_filtering changes, and the handling of tagged frames with a
VID that has no 4K entry is still unknown, so I would like to do it as a
separate follow-up with testing on hardware.
Best regards,
Mieczyslaw Nalewaj