RE: [PATCH rtw-next v7 5/5] wifi: rtw89: honor ASSIGN_SEQ, retries, and NO_ACK for injected frames

From: Ping-Ke Shih

Date: Thu Nov 19 2026 - 02:28:41 EST


Enver Ikromov <owner@xxxxxxxxxxxxxx> wrote:
> Injected management frames currently overwrite caller-supplied sequence
> numbers because hardware sequence numbering remains enabled when
> IEEE80211_TX_CTL_ASSIGN_SEQ is unset, and injected frames ignore NO_ACK
> and explicit radiotap retry limits.
>
> Preserve the caller's sequence number when IEEE80211_TX_CTL_ASSIGN_SEQ
> is not set, apply NO_ACK in TX descriptors and completion status, and
> honor radiotap retry counts up to RTW89_TX_DATA_CNT_LMT_MAX (63).

Since RTL8852AE doesn't have NO_ACK in TX descriptor, so please note this
in commit message.

> @@ -1800,7 +1814,9 @@ static __le32 rtw89_build_txwd_body5_v2(struct rtw89_tx_desc_info *desc_info)
>
> static __le32 rtw89_build_txwd_body6_v2(struct rtw89_tx_desc_info *desc_info)
> {
> - u32 dword = FIELD_PREP(BE_TXD_BODY6_UPD_WLAN_HDR, desc_info->upd_wlan_hdr);
> + u32 dword = FIELD_PREP(BE_TXD_BODY6_NO_ACK, desc_info->no_ack) |
> + FIELD_PREP(BE_TXD_BODY6_UPD_WLAN_HDR,
> + desc_info->upd_wlan_hdr);

Just straighten as original (a little over 80 characters).