Re: [PATCH v3 10/10] drm/panthor: Skip devfreq when no OPP table is present
From: Boris Brezillon
Date: Thu Nov 19 2026 - 03:13:09 EST
On Wed, 18 Nov 2026 17:53:26 +0000
Karunika Choo <karunika.choo@xxxxxxx> wrote:
> On Mali v15 AM systems, frequency scaling is handled outside panthor by
> the AM_GOVERNOR block, so the GPU DT node may not provide an OPP table.
>
> Make panthor_devfreq_init() return early when dev_pm_opp_get_opp_table()
> returns -ENODEV, and guard the devfreq helper paths against a missing
> devfreq instance. Also make it so that frequency can be queried even if
> the devfreq instance is missing.
>
> This keeps devfreq enabled for existing platforms while allowing v15 AM
> systems to probe without a local devfreq setup.
>
> Reviewed-by: Liviu Dudau <liviu.dudau@xxxxxxx>
> Signed-off-by: Karunika Choo <karunika.choo@xxxxxxx>
> ---
> v3:
> - Omit drm-maxfreq-panthor from fdinfo when the maximum frequency
> is unknown, as on AM systems without an OPP table.
> v2:
> - Directly call functions instead of storing function pointers.
> - Picked up R-b from Liviu
> v1:
> - Only skip panthor_devfreq init when OPP lookup returns -ENODEV instead
> of direct DT-property check.
> - Support frequency query without devfreq.
>
> drivers/gpu/drm/panthor/panthor_devfreq.c | 29 +++++++++++++++++------
> drivers/gpu/drm/panthor/panthor_drv.c | 5 +++-
> drivers/gpu/drm/panthor/panthor_hw.h | 6 +++++
> 3 files changed, 32 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/panthor/panthor_devfreq.c b/drivers/gpu/drm/panthor/panthor_devfreq.c
> index 2249b41ca4afe..d1814b5197221 100644
> --- a/drivers/gpu/drm/panthor/panthor_devfreq.c
> +++ b/drivers/gpu/drm/panthor/panthor_devfreq.c
> @@ -12,6 +12,7 @@
>
> #include "panthor_devfreq.h"
> #include "panthor_device.h"
> +#include "panthor_hw.h"
>
> /**
> * struct panthor_devfreq - Device frequency management
> @@ -164,6 +165,19 @@ int panthor_devfreq_init(struct panthor_device *ptdev)
> */
> table = dev_pm_opp_get_opp_table(dev);
> if (IS_ERR_OR_NULL(table)) {
> + /*
> + * On v15 GPUs, frequency scaling is handled outside of panthor
> + * by the AM_GOVERNOR block, so the GPU DT node may not provide
> + * an OPP table. In such cases, do not initialize devfreq for
> + * panthor.
> + */
> + if (panthor_hw_is_gen5_am(ptdev->base.dev) &&
Could we have a property in panthor_hw or panthor_soc_data that
reflects whether devfreq is delegated or not, and move this commit
before the one introducing v15 support?
> + PTR_ERR(table) == -ENODEV) {
> + drmm_kfree(&ptdev->base, pdevfreq);
> + ptdev->devfreq = NULL;
> + return 0;
> + }
> +