Re: [PATCH v12 2/5] drm/imx: Add support for i.MX94 DCIF

From: Luca Ceresoli

Date: Thu Nov 19 2026 - 03:32:40 EST


> The i.MX94 Display Control Interface features:
> * Up to maximum 3 layers of alpha blending:
> - 1 background layer(Layer 0);
> - 1 foreground layer(Layer 1);
> - A programmable constant color behind the background layer;
> * Each layer supports:
> - programmable plane size;
> - programmable background color;
> - embedded alpha and global alpha;
> * Data output with CRC checksum for 4 programmable regions;
>
> Reviewed-by: Luca Ceresoli <luca.ceresoli@xxxxxxxxxxx> # bridge refcounting
> Signed-off-by: Sandor Yu <sandor.yu@xxxxxxx>
> Co-developed-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx>
> Signed-off-by: Laurentiu Palcu <laurentiu.palcu@xxxxxxxxxxx>

Looks good, but there are some issues reported by sashiko. Can you either
fix them or explain why the code is OK?

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com