Re: [PATCH] mtd: rawnand: stop BBT creation when the marker scan fails

From: James Hilliard

Date: Thu Nov 19 2026 - 05:41:01 EST


On Thu, Nov 19, 2026 at 3:19 AM Miquel Raynal <miquel.raynal@xxxxxxxxxxx> wrote:
>
>
> >> >> I would prefer if you could write your own commit logs, giving us more
> >> >> confidence on the work that has been asked. You can use an LLM to
> >> >> improve/enhance it obviously.
> >> >
> >> > To be honest I've never been great at writing commit messages in
> >> > general and have gotten a lot more complaints about commit messages
> >> > missing important details prior to using LLM's. I can barely tell the
> >>
> >> For me the code is getting better but the commit logs are unclear. Some
> >> details which don't need (imo) to be written are there, and the big
> >> picture is often missing or not clearly stated before the details.
> >>
> >> Don't get me wrong, using an LLM to refine/reword/reorganize is fine,
> >> but letting the LLM write it entirely is not working well.
> >
> > I guess the issue is that I often don't have the best understanding
> > of what the big picture that needs explanation in the commit messages
> > is some of the time, if I did then I would then just instruct the LLM to
> > make those edits whenever I review patches before sending them.
> >
> > I think I just don't have good intuition when it comes to predicting what is
> > important to explain in commit messages.
>
> I get it, but for someone submitting this many patches, that lack of
> understanding is precisely the problem: delegating the wording to an LLM
> when you don't know the rationale doesn't remove the cost, it just
> shifts it onto others.

It's a bit tricky since it's not that I don't have any rationale, it's more
that I don't always have the best big picture rationale since that's a
bit more subjective.

The rationale I'm using is generally more related to a TLA+ test
and/or fault injection test that was used to confirm/discover the bug.

I guess the issue is probably that the pathway used to prove the
bug can be somewhat detached from the bigger picture.

I've tweaked my workflows to do more analysis to try and derive
the bigger picture rationale for better commit messages rather
than focusing as much on the most proximal failure pathway to
the bug. Hopefully from there it will be more obvious what the
commit message should focus on.