Re: [PATCH 06/15] dt-bindings: firmware: xilinx: Add Versal Gen 2 compatible string

From: Krzysztof Kozlowski

Date: Thu Nov 19 2026 - 05:53:50 EST


On 19/11/2026 00:32, Gregory Williams wrote:
> From: Senthil Nathan Thangaraj <senthilnathan.thangaraj@xxxxxxx>
>
> Add compatible string for Versal Gen 2 firmware driver.
>
> Signed-off-by: Michal Simek <michal.simek@xxxxxxx>
> Signed-off-by: Senthil Nathan Thangaraj <senthilnathan.thangaraj@xxxxxxx>

Incomplete DCO

> ---
> .../bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> index 72af37cdb103..60d1bd329d0e 100644
> --- a/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> +++ b/Documentation/devicetree/bindings/firmware/xilinx/xlnx,zynqmp-firmware.yaml
> @@ -32,6 +32,9 @@ properties:
> - xlnx,versal-net-firmware
> - const: xlnx,versal-firmware
>
> + - description: For implementations complying for Versal Gen 2.

Drop description, it duplicates the compatible. Or say something useful.
This should be rather enum with all such entries.

> + const: xlnx,versal2-firmware
> +


Best regards,
Krzysztof