Re: [PATCH v3 18/31] net: phy: Use the compatibility driver attachment API

From: Andrew Lunn

Date: Thu Nov 19 2026 - 08:31:52 EST


On Thu, Nov 19, 2026 at 09:18:11AM +0200, Leon Romanovsky wrote:
> On Wed, Nov 18, 2026 at 09:21:45PM +0100, Andrew Lunn wrote:
> > > @@ -3813,6 +3809,8 @@ static int phy_probe(struct device *dev)
> > > int err = 0;
> > >
> > > phydev->drv = phydrv;
> > > + phydev->is_genphy_driven = phydrv == &genphy_driver ||
> > > + phydrv == &genphy_c45_driver;
> > >
> >
> > Why do this here?
>
> This flag marks that driver is already probed, which is reliably
> happening in phy_probe() under right locks. It was the easiest
> way to battle AI reviews which don't agree with how PHY subsystem
> performs driver bound.

I've not seen the netdev LLM do a review yet. It will be interesting
to see what it says.

Andrew