Re: [PATCH v1] platform/x86: ISST: Propagate def_ioctl errors to user space

From: Ilpo Järvinen

Date: Thu Nov 19 2026 - 09:43:46 EST


On Mon, 16 Nov 2026 13:02:09 -0800, Kuppuswamy Sathyanarayanan wrote:

> isst_if_def_ioctl() declares an inner "int ret" that shadows the outer
> "long ret". When the TPMI def_ioctl callback fails, its error is lost
> and user space always sees -ENOTTY.
>
> Remove the inner variable. Return the callback result unless it is
> -ENOTTY.
>
> [...]

Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

FYI [if applicable to your patch], as per Linus' policy change, also
fixes are mostly routed through for-next unless the fix is for a
commit introduced in the most recent cycle or is clearly a regression
fix.

The list of commits applied:
[1/1] platform/x86: ISST: Propagate def_ioctl errors to user space
commit: 74a0cee01b1ce34a09f6fc4531418b185c88d161

--
i.