"Bombeeck, Jack" <Jack.Bombeeck@Onstream.com> ,in message <15BE211FD9CBD211BAC4
0090273A97EB60864A@EMAIL>, wrote:
> You wrote:
> > Your mailer horribly mangled the patch and it is unusable.
>
> Well, I'll attach it again.
It was mangled in the exact same way. Fortunately, I was able to decipher
the "quoted-printable" format and apply the patch.
Unfortunately, I get the following errors during "make modules" in the
context of a 2.2.13 kernel.
ide-tape.c: In function `idetape_end_request':
ide-tape.c:1746: warning: long unsigned int format, unsigned int arg (arg 2)
ide-tape.c: In function `idetape_read_position_callback':
ide-tape.c:2973: warning: long unsigned int format, unsigned int arg (arg 2)
ide-tape.c: In function `idetape_onstream_write_error_recovery':
ide-tape.c:3364: warning: long unsigned int format, unsigned int arg (arg 3)
ide-tape.c: In function `idetape_verify_stage':
ide-tape.c:3496: warning: long unsigned int format, unsigned int arg (arg 3)
ide-tape.c:3520: warning: long unsigned int format, unsigned int arg (arg 5)
ide-tape.c:3529: warning: long unsigned int format, unsigned int arg (arg 3)
ide-tape.c: In function `idetape_init':
ide-tape.c:5860: warning: `tape' might be used uninitialized in this function
It appears the ntohl function is actually a macro that parenthesizes its
argument (whee) which means that when you pass in an unsigned int, you get
back an unsigned int so you should probably cast each return value of ntohl to
an unsigned long to suppress this error message.
I guess the long-term fix would be to change the definition of the macro
ntohl in /usr/include/netinet/in.h (as opposed to the function declaration for
ntohl; argh) to be
# define ntohl(x) ((unsigned long)(x))
Since unsigned long and unsigned int on the i386 are the same size, this is
only a cosmetic error for me, but should still be addressed.
We'll see if the patched driver can make my OnStream act less wacky. After
successfully filling around 10 tapes, I've had two tapes in a row (from the
same box) which write out fine, but get errors reading logical block 0. PITA
> Content-Transfer-Encoding: quoted-printable
> Content-Disposition: attachment;
> filename="ide-tape-1.16e1-2.2.x.c.patch"
>
> --- ide-tape-1.16e-2.2.x.c Thu Oct 14 01:28:07 1999
> +++ ide-tape-1.16e1-2.2.x.c Thu Oct 14 01:28:25 1999
> @@ -225,6 +225,61 @@
> * Decrease the default disconnection time to =
> tn.
> * Ver 1.16e Oct 3 99 Minor fixes.
> *
> + * Ver 1.16e1 Oct 13 99 Patches by Arnold Niessen,
> + * niessen@iae.nl / =
> arnold.niessen@philips.com
> + * GO-1) Undefined code in idetape_read_position
> + * according to Gadi's email
> + * AJN-1) Minor fix asc =3D=3D 11 should be asc =
> =3D=3D 0x11
> + * in idetape_issue_packet_command (did =
--
Bob Forsman thoth@gainesville.fl.us
http://www.gainesville.fl.us/~thoth/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:18 EST