Re: timer_bh robusteness fix against potential deadlocks

From: tytso@valinux.com
Date: Wed Jan 12 2000 - 14:23:45 EST


   Date: Wed, 12 Jan 2000 20:12:54 +0100 (CET)
   From: Andrea Arcangeli <andrea@suse.de>

>It adds one conditional inside a rare 'if' case, so it's not a
>performance issue, and it means that the next time something like this
>happens, the machine will cleanly panic, and leave a very easy to
>understand indication of what went wrong.

   I don't like a panic for a thing that we can recover gracefully and
   allowing the user to also see the message even if he was running under X 8).

Fine,so make it set a standard timeout and do a printk instead. This is
a "never can happen" situation, right?

        if (!timeout) {
                timeout = tp->rto;
                if (!timeout) {
                        printk("Bugcheck: tcp_send_delayed_ack ato and rto are 0");
                        timeout = HZ/50;
        }

                                                        - Ted

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/



This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:23 EST