On Sat, 15 Jan 2000, Guest section DW wrote:
> On Thu, Jan 13, 2000 at 09:06:59PM -0500, Alexander Viro wrote:
> >
> > OK, could somebody explain where does IDE call ide_geninit() if built as
> > module? And if it (apparently) doesn't, do we need it in built-in case?
> > Andre, could you comment on that?
It should be moved from ide.c to ide-probe.c, for modules I think.
grep -in "ide_geninit" *
ide-probe.c:643: * init_gendisk() (as opposed to ide_geninit) is called for each major device,
ide-probe.c:645: * structures needed for the routines in genhd.c. ide_geninit() gets called
ide-probe.c:692: gd->init = &ide_geninit; /* initialization function */
ide.c:551: * ide_geninit() is called exactly *once* for each major, from genhd.c,
ide.c:554:void ide_geninit (struct gendisk *gd)
ide.c:3402:EXPORT_SYMBOL(ide_geninit);
grep: paride: Is a directory
There is no reason to export, if we move it to "ide-probe.c" where it is
called. I will test this move and it has to be harmless.
Will rip a patch against linux-2.3.40-4 and get it out tonight if every
thing is cool........
> I am not Andre, and probably also late - vger stuff arrives here
> with a delay of more than 24 hours. But let me see.
> So, just deleting the dev->init(dev); call here will fail, I think.
ide-probe.c:692: gd->init = &ide_geninit; /*initialization function */
include/linux/ide.h:760:void ide_geninit (struct gendisk *gd);
> Note that scsi also has sd_geninit().
>
> Andries
Andries,
Where are all the callbacks to "dev->init(dev)" located for block?
Andre Hedrick
The Linux IDE guy
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/
This archive was generated by hypermail 2b29 : Sat Jan 15 2000 - 21:00:25 EST