Re: [PATCH] bug in non-blocking use of sound driver

• Next message: Theodore Y. Ts'o: "Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1"
• Previous message: Mike A. Harris: "Sockets stuck in FIN_WAIT1 (2.2.14)"
• In reply to: Eric Lammerts: "[PATCH] bug in non-blocking use of sound driver"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

[ Wednesday, January 19, 2000 ] Eric Lammerts wrote:
> +
> + if ((file->f_flags & O_NONBLOCK) && buf_no == -EAGAIN)
> + return -EAGAIN;
>
> return buf_no;
> }

You could leave out adding this section since the if() is only
sucessful for buf_no == -EAGAIN and in that scenario we might
as well just use the "return buf_no" already in place...

code removal like this always makes patches more likely to be
accepted, and reducing lines of code is a Good Thing :)

James

-- 
Miscellaneous Engineer --- IBM Netfinity Performance Development
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.rutgers.edu
Please read the FAQ at http://www.tux.org/lkml/

• Next message: Theodore Y. Ts'o: "Re: [Patch] Cleanup struct gendisk registration, 2.3.40-pre1"
• Previous message: Mike A. Harris: "Sockets stuck in FIN_WAIT1 (2.2.14)"
• In reply to: Eric Lammerts: "[PATCH] bug in non-blocking use of sound driver"
• Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Sun Jan 23 2000 - 21:00:21 EST