Re: [PATCH] Wrong errno out of memory in open syscall

From: Pavel Machek (pavel@suse.cz)
Date: Fri Jan 28 2000 - 16:32:24 EST

Next message: Michael Schulz: "Re: Strange scheduling behavoir in SMP (kernel 2.2.14)"
Previous message: Brian Hall: "Re: Reverse engineering Windows drivers."
In reply to: Alan Cox: "Re: [PATCH] Wrong errno out of memory in open syscall"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Hi!

> > It's a simple one line patch, below.
> >
> > --- linux-2.3.40/fs/ext2/namei.c Fri Jan 28 16:23:32 2000
> > +++ linux/fs/ext2/namei.c Fri Jan 28 16:40:41 2000
> > @@ -176,7 +176,7 @@
> > inode = iget(dir->i_sb, ino);
> >
> > if (!inode)
> > - return ERR_PTR(-EACCES);
> > + return ERR_PTR(-ENOMEM);
> > }
> > d_add(dentry, inode);
> > return NULL;
>
> ENOMEM isnt a valid return to open() except for a streams file. Quite why
> SuS specifies this I dont know.

Man pages with

Linux 2.0.32 December 20, 1996 4

on them say ENOMEM is to be expected, and it is way better than
telling people that EACCES. I think we should ignore SuS in this case.

Pavel

-- I'm pavel@ucw.cz. "In my country we have almost anarchy and I don't care." Panos Katsaloulis describing me w.r.t. patents me at discuss@linmodems.org

- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.rutgers.edu Please read the FAQ at http://www.tux.org/lkml/

Next message: Michael Schulz: "Re: Strange scheduling behavoir in SMP (kernel 2.2.14)"
Previous message: Brian Hall: "Re: Reverse engineering Windows drivers."
In reply to: Alan Cox: "Re: [PATCH] Wrong errno out of memory in open syscall"
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

This archive was generated by hypermail 2b29 : Mon Jan 31 2000 - 21:00:29 EST